Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2069483002: Refactor common portions of the two SDK implementations into a base class (Closed)

Created:
4 years, 6 months ago by Brian Wilkerson
Modified:
4 years, 6 months ago
Reviewers:
pquitslund
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Refactor common portions of the two SDK implementations into a base class R=pquitslund@google.com Committed: https://github.com/dart-lang/sdk/commit/dc7fb35bd4bf04ea55d2dccca81a443cd03a6cfc

Patch Set 1 #

Patch Set 2 : clean-up #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+417 lines, -352 lines) Patch
M pkg/analyzer/lib/source/embedder.dart View 4 chunks +9 lines, -86 lines 0 comments Download
M pkg/analyzer/lib/src/generated/sdk_io.dart View 1 10 chunks +211 lines, -131 lines 4 comments Download
M pkg/analyzer/test/source/embedder_test.dart View 2 chunks +196 lines, -134 lines 0 comments Download
M pkg/analyzer_cli/lib/src/build_mode.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
4 years, 6 months ago (2016-06-14 00:27:18 UTC) #2
pquitslund
LGTM! https://codereview.chromium.org/2069483002/diff/20001/pkg/analyzer/lib/src/generated/sdk_io.dart File pkg/analyzer/lib/src/generated/sdk_io.dart (right): https://codereview.chromium.org/2069483002/diff/20001/pkg/analyzer/lib/src/generated/sdk_io.dart#newcode36 pkg/analyzer/lib/src/generated/sdk_io.dart:36: LibraryMap libraryMap = new LibraryMap(); Any reason not ...
4 years, 6 months ago (2016-06-14 17:50:59 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/2069483002/diff/20001/pkg/analyzer/lib/src/generated/sdk_io.dart File pkg/analyzer/lib/src/generated/sdk_io.dart (right): https://codereview.chromium.org/2069483002/diff/20001/pkg/analyzer/lib/src/generated/sdk_io.dart#newcode36 pkg/analyzer/lib/src/generated/sdk_io.dart:36: LibraryMap libraryMap = new LibraryMap(); Yes. Unless we change ...
4 years, 6 months ago (2016-06-14 20:53:04 UTC) #4
Brian Wilkerson
4 years, 6 months ago (2016-06-16 15:57:36 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
dc7fb35bd4bf04ea55d2dccca81a443cd03a6cfc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698