Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Unified Diff: src/wasm/asm-types.h

Issue 2069443002: V8. ASM-2-WASM. Changes the asm-types library. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Removes clamped array. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/wasm/asm-types.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/wasm/asm-types.h
diff --git a/src/wasm/asm-types.h b/src/wasm/asm-types.h
index 303e5cdf8893ae26e0d780dedbc0a9ddafc3b654..ba6d0985a84cf2919eabfdb42ac43a0feae1a0c6 100644
--- a/src/wasm/asm-types.h
+++ b/src/wasm/asm-types.h
@@ -47,8 +47,9 @@ class AsmOverloadedFunctionType;
V(Int32Array, "Int32Array", 19, kAsmHeap) \
V(Float32Array, "Float32Array", 20, kAsmHeap) \
V(Float64Array, "Float64Array", 21, kAsmHeap) \
- V(FloatishDoubleQ, "floatish|double?", 22, kAsmFloatish | kAsmDoubleQ) \
- V(FloatQDoubleQ, "float?|double?", 23, kAsmFloatQ | kAsmDoubleQ) \
+ /* Pseudo-types used in representing heap access for fp types.*/ \
bradn 2016/06/14 20:59:04 Do you actually end up needing these?
John 2016/06/14 21:06:16 Not yet, but the validator needs to be able to rep
+ V(FloatishDoubleQ, "floatish|double?", 23, kAsmFloatish | kAsmDoubleQ) \
+ V(FloatQDoubleQ, "float?|double?", 24, kAsmFloatQ | kAsmDoubleQ) \
/* None is used to represent errors in the type checker. */ \
V(None, "<none>", 31, 0)
@@ -200,10 +201,10 @@ class AsmType {
}
// The type for fround(src).
- static AsmType* FroundType(Zone* zone, AsmType* src);
+ static AsmType* FroundType(Zone* zone);
// The (variadic) type for min and max.
- static AsmType* MinMaxType(Zone* zone, AsmType* type);
+ static AsmType* MinMaxType(Zone* zone, AsmType* dest, AsmType* src);
std::string Name();
// IsExactly returns true if this is the exact same type as that. For
« no previous file with comments | « no previous file | src/wasm/asm-types.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698