V8. ASM-2-WASM. Changes the asm-types library.

V8. ASM-2-WASM. Changes the asm-types library.

The modifications were necessary to properly represent asm types:

1) fround is no longer an overloaded function.

2) the constructor for MinMaxTypes now takes a return type.

3) Adds pseudo-types for representing the Load/Store types for fp heap views.
BUG=

Committed: https://crrev.com/201cd479d60821434488bedbd4094465b03a870f
Cr-Commit-Position: refs/heads/master@{#36980}

[John, 2016-06-13 21:55:06]

Description was changed from

==========
V8. ASM-2-WASM. Changes the asm-types library.

The modifications were necessary to properly represent asm types:

1) fround is no longer an overloaded function.
2) the constructor for MinMaxTypes now takes a return type.
3) Uint8ClampedArray is added to the list of allowed heap view types.
   This might be a non-specs-conformant, but it is needed because the
   TYPED_ARRAYS macro has it.

BUG=
==========

to

==========
V8. ASM-2-WASM. Changes the asm-types library.

The modifications were necessary to properly represent asm types:

1) fround is no longer an overloaded function.

2) the constructor for MinMaxTypes now takes a return type.

3) Uint8ClampedArray is added to the list of allowed heap view types. This might
be a non-specs-conformant, but it is needed because the TYPED_ARRAYS macro has
it.

4) Adds pseudo-types for representing the Load/Store types for fp heap views.
BUG=
==========

[John, 2016-06-13 22:37:19]

jpp@chromium.org changed reviewers:
+ bradnelson@chromium.org

[bradnelson, 2016-06-13 22:42:10]

So clamped isn't allowed, perhaps factor TYPED_ARRAYS into
TYPED_ARRAYS_UNCLAMPED + the one clamped, rather than let that pollute the type
system here?

https://codereview.chromium.org/2069443002/diff/1/src/wasm/asm-types.h
File src/wasm/asm-types.h (right):

https://codereview.chromium.org/2069443002/diff/1/src/wasm/asm-types.h#newcode50
src/wasm/asm-types.h:50: V(Uint8ClampedArray, "Uint8CampledArray", 22, kAsmHeap)
                    \
Campled -> Clamped

However, I believe this one is forbidden as you suggest.

[John, 2016-06-14 14:55:02]

try bots are trying.

https://codereview.chromium.org/2069443002/diff/1/src/wasm/asm-types.h
File src/wasm/asm-types.h (right):

https://codereview.chromium.org/2069443002/diff/1/src/wasm/asm-types.h#newcode50
src/wasm/asm-types.h:50: V(Uint8ClampedArray, "Uint8CampledArray", 22, kAsmHeap)
                    \
On 2016/06/13 22:42:10, bradnelson wrote:
> Campled -> Clamped
> 
> However, I believe this one is forbidden as you suggest.

But Campled is moar nice. :)

Anyway, I removed references to the clamped array type. I think it is better to

#define ASM_ARRAY_TYPES

in typing-asm.cc instead of using the v8 macro. thoughts?

[John, 2016-06-14 14:56:38]

Description was changed from

==========
V8. ASM-2-WASM. Changes the asm-types library.

The modifications were necessary to properly represent asm types:

1) fround is no longer an overloaded function.

2) the constructor for MinMaxTypes now takes a return type.

3) Uint8ClampedArray is added to the list of allowed heap view types. This might
be a non-specs-conformant, but it is needed because the TYPED_ARRAYS macro has
it.

4) Adds pseudo-types for representing the Load/Store types for fp heap views.
BUG=
==========

to

==========
V8. ASM-2-WASM. Changes the asm-types library.

The modifications were necessary to properly represent asm types:

1) fround is no longer an overloaded function.

2) the constructor for MinMaxTypes now takes a return type.

3) Adds pseudo-types for representing the Load/Store types for fp heap views.
BUG=
==========

[bradn, 2016-06-14 20:59:03]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[bradn, 2016-06-14 20:59:04]

sgtm me on a separate list.

https://codereview.chromium.org/2069443002/diff/20001/src/wasm/asm-types.h
File src/wasm/asm-types.h (right):

https://codereview.chromium.org/2069443002/diff/20001/src/wasm/asm-types.h#ne...
src/wasm/asm-types.h:50: /* Pseudo-types used in representing heap access for fp
types.*/            \
Do you actually end up needing these?

[John, 2016-06-14 21:06:16]

https://codereview.chromium.org/2069443002/diff/20001/src/wasm/asm-types.h
File src/wasm/asm-types.h (right):

https://codereview.chromium.org/2069443002/diff/20001/src/wasm/asm-types.h#ne...
src/wasm/asm-types.h:50: /* Pseudo-types used in representing heap access for fp
types.*/            \
On 2016/06/14 20:59:04, bradn wrote:
> Do you actually end up needing these?

Not yet, but the validator needs to be able to represent these types.

[bradnelson, 2016-06-14 22:58:56]

Ah, I see lgtm

[bradnelson, 2016-06-14 22:59:08]

The CQ bit was checked by bradnelson@chromium.org

[commit-bot: I haz the power, 2016-06-14 22:59:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2069443002/40001

[commit-bot: I haz the power, 2016-06-14 23:03:12]

Description was changed from

==========
V8. ASM-2-WASM. Changes the asm-types library.

The modifications were necessary to properly represent asm types:

1) fround is no longer an overloaded function.

2) the constructor for MinMaxTypes now takes a return type.

3) Adds pseudo-types for representing the Load/Store types for fp heap views.
BUG=
==========

to

==========
V8. ASM-2-WASM. Changes the asm-types library.

The modifications were necessary to properly represent asm types:

1) fround is no longer an overloaded function.

2) the constructor for MinMaxTypes now takes a return type.

3) Adds pseudo-types for representing the Load/Store types for fp heap views.
BUG=
==========

[commit-bot: I haz the power, 2016-06-14 23:03:13]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-14 23:05:08]

Description was changed from

==========
V8. ASM-2-WASM. Changes the asm-types library.

The modifications were necessary to properly represent asm types:

1) fround is no longer an overloaded function.

2) the constructor for MinMaxTypes now takes a return type.

3) Adds pseudo-types for representing the Load/Store types for fp heap views.
BUG=
==========

to

==========
V8. ASM-2-WASM. Changes the asm-types library.

The modifications were necessary to properly represent asm types:

1) fround is no longer an overloaded function.

2) the constructor for MinMaxTypes now takes a return type.

3) Adds pseudo-types for representing the Load/Store types for fp heap views.
BUG=

Committed: https://crrev.com/201cd479d60821434488bedbd4094465b03a870f
Cr-Commit-Position: refs/heads/master@{#36980}
==========

[commit-bot: I haz the power, 2016-06-14 23:05:09]

Patchset 3 (id:??) landed as
https://crrev.com/201cd479d60821434488bedbd4094465b03a870f
Cr-Commit-Position: refs/heads/master@{#36980}