Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2069413003: Revert of Worker: Protect a running debugger task from forcible worker termination (2) (Closed)

Created:
4 years, 6 months ago by Henrik Grunell
Modified:
4 years, 6 months ago
Reviewers:
kinuko, nhiroki
CC:
chromium-reviews, blink-reviews, kinuko+worker_chromium.org, falken, blink-worker-reviews_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@avoid_debugger_task
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Worker: Protect a running debugger task from forcible worker termination (2) (patchset #1 id:180001 of https://codereview.chromium.org/2046483002/ ) Reason for revert: Two compositorworker tests have failed flakily after the CL this CL depends on landed: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20ASAN/builds/24612 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20ASAN/builds/24613 Need to revert this first. Original issue's description: > Worker: Protect a running debugger task from forcible worker termination (2) > > A running debugger task must be protected from forcible worker termination, but > in the current implementation, there is a corner case where the debugger task > can suddenly be killed as follows: > > 1) terminate() is called while a debugger task is running. This does not > schedule a task to forcibly terminate the worker execution. > 2) terminateAndWait() is called while a debugger task is still running. This > attempts to overtake the scheduled (actually not scheduled) termination task > and forcibly terminates the worker execution. > 3) The running debugger task is interrupted and possibly crashes. > > After this change, terminateAndWait() respects the running debugger task on the > step 2). > > BUG=616775 > > Committed: https://crrev.com/39ce89cd7e60e2f20925eb332d9d9735185425f4 > Cr-Commit-Position: refs/heads/master@{#400120} TBR=kinuko@chromium.org,nhiroki@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=616775 Committed: https://crrev.com/69876da721cf98624ded28086bf7f1107057e047 Cr-Commit-Position: refs/heads/master@{#400134}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -54 lines) Patch
M third_party/WebKit/Source/core/workers/WorkerThread.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThread.cpp View 3 chunks +5 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp View 6 chunks +10 lines, -38 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Henrik Grunell
Created Revert of Worker: Protect a running debugger task from forcible worker termination (2)
4 years, 6 months ago (2016-06-16 11:55:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069413003/1
4 years, 6 months ago (2016-06-16 11:56:02 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-16 11:56:35 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 11:57:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/69876da721cf98624ded28086bf7f1107057e047
Cr-Commit-Position: refs/heads/master@{#400134}

Powered by Google App Engine
This is Rietveld 408576698