DescriptionRevert of Worker: Protect a running debugger task from forcible worker termination (2) (patchset #1 id:180001 of https://codereview.chromium.org/2046483002/ )
Reason for revert:
Two compositorworker tests have failed flakily after the CL this CL depends on landed:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20ASAN/builds/24612
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20ASAN/builds/24613
Need to revert this first.
Original issue's description:
> Worker: Protect a running debugger task from forcible worker termination (2)
>
> A running debugger task must be protected from forcible worker termination, but
> in the current implementation, there is a corner case where the debugger task
> can suddenly be killed as follows:
>
> 1) terminate() is called while a debugger task is running. This does not
> schedule a task to forcibly terminate the worker execution.
> 2) terminateAndWait() is called while a debugger task is still running. This
> attempts to overtake the scheduled (actually not scheduled) termination task
> and forcibly terminates the worker execution.
> 3) The running debugger task is interrupted and possibly crashes.
>
> After this change, terminateAndWait() respects the running debugger task on the
> step 2).
>
> BUG=616775
>
> Committed: https://crrev.com/39ce89cd7e60e2f20925eb332d9d9735185425f4
> Cr-Commit-Position: refs/heads/master@{#400120}
TBR=kinuko@chromium.org,nhiroki@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=616775
Committed: https://crrev.com/69876da721cf98624ded28086bf7f1107057e047
Cr-Commit-Position: refs/heads/master@{#400134}
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|