Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2069373002: [counter] Adding missing compile counters (Closed)

Created:
4 years, 6 months ago by Camillo Bruni
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com, Michael Starzinger
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[counter] Adding missing runtime call counters in the compiler BUG= Committed: https://crrev.com/44bf44f3dc6e51cc707a358c28435268a48a9724 Cr-Commit-Position: refs/heads/master@{#37066}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M src/compiler.cc View 9 chunks +15 lines, -0 lines 0 comments Download
M src/counters.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Camillo Bruni
PTAL
4 years, 6 months ago (2016-06-16 07:20:20 UTC) #3
Jarin
lgtm, cc'ing Michi because he might have more insight.
4 years, 6 months ago (2016-06-16 20:27:07 UTC) #4
Michael Starzinger
LGTM. I still think the names don't make much sense, but at least it is ...
4 years, 6 months ago (2016-06-17 08:15:34 UTC) #6
Camillo Bruni
On 2016/06/17 at 08:15:34, mstarzinger wrote: > LGTM. I still think the names don't make ...
4 years, 6 months ago (2016-06-17 11:33:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069373002/1
4 years, 6 months ago (2016-06-17 11:33:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-17 12:04:04 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 12:04:58 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/44bf44f3dc6e51cc707a358c28435268a48a9724
Cr-Commit-Position: refs/heads/master@{#37066}

Powered by Google App Engine
This is Rietveld 408576698