Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2069363002: PPC: use Cmpi to handle case when kMaxRegularHeapObjectSize > 16bits (Closed)

Created:
4 years, 6 months ago by JaideepBajwa
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: use Cmpi to handle case when kMaxRegularHeapObjectSize > 16bits R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Committed: https://crrev.com/3adefd712cb4717eb28ecd71a715da36ed5404cd Cr-Commit-Position: refs/heads/master@{#37022}

Patch Set 1 #

Patch Set 2 : fix spacing issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/ppc/code-stubs-ppc.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
JaideepBajwa
PTAL
4 years, 6 months ago (2016-06-16 05:04:21 UTC) #1
john.yan
lgtm
4 years, 6 months ago (2016-06-16 05:11:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069363002/20001
4 years, 6 months ago (2016-06-16 05:15:50 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-16 05:47:22 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 05:50:00 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3adefd712cb4717eb28ecd71a715da36ed5404cd
Cr-Commit-Position: refs/heads/master@{#37022}

Powered by Google App Engine
This is Rietveld 408576698