Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: components/cronet/android/cronet_url_request_adapter.cc

Issue 2069303002: Add new Cronet exception class for QUIC errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: header Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/cronet_url_request_adapter.cc
diff --git a/components/cronet/android/cronet_url_request_adapter.cc b/components/cronet/android/cronet_url_request_adapter.cc
index 172757fe2a2caca7b2716ec09763ecd90a5e2231..5ac21c995e6f8721f938e4d3228443ea3034263a 100644
--- a/components/cronet/android/cronet_url_request_adapter.cc
+++ b/components/cronet/android/cronet_url_request_adapter.cc
@@ -23,6 +23,7 @@
#include "net/http/http_response_headers.h"
#include "net/http/http_status_code.h"
#include "net/http/http_util.h"
+#include "net/quic/quic_protocol.h"
#include "net/ssl/ssl_info.h"
#include "net/url_request/redirect_info.h"
#include "net/url_request/url_request_context.h"
@@ -235,6 +236,7 @@ void CronetURLRequestAdapter::OnSSLCertificateError(
JNIEnv* env = base::android::AttachCurrentThread();
cronet::Java_CronetUrlRequest_onError(
env, owner_.obj(), NetErrorToUrlRequestError(net_error), net_error,
+ net::QUIC_NO_ERROR,
ConvertUTF8ToJavaString(env, net::ErrorToString(net_error)).obj(),
request->GetTotalReceivedBytes());
}
@@ -368,11 +370,14 @@ bool CronetURLRequestAdapter::MaybeReportError(net::URLRequest* request) const {
if (url_request_->status().is_success())
return false;
int net_error = url_request_->status().error();
+ net::NetErrorDetails net_error_details;
+ url_request_->PopulateNetErrorDetails(&net_error_details);
VLOG(1) << "Error " << net::ErrorToString(net_error)
<< " on chromium request: " << initial_url_.possibly_invalid_spec();
JNIEnv* env = base::android::AttachCurrentThread();
cronet::Java_CronetUrlRequest_onError(
env, owner_.obj(), NetErrorToUrlRequestError(net_error), net_error,
+ net_error_details.quic_connection_error,
ConvertUTF8ToJavaString(env, net::ErrorToString(net_error)).obj(),
request->GetTotalReceivedBytes());
return true;

Powered by Google App Engine
This is Rietveld 408576698