Add new Cronet exception class for QUIC errors

components/cronet/android/java/src/org/chromium/net/CronetBidirectionalStream.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.net;
 
 import org.chromium.base.Log;
 import org.chromium.base.VisibleForTesting;
 import org.chromium.base.annotations.CalledByNative;
 import org.chromium.base.annotations.JNINamespace;
@@ skipping 537 matching lines @@
                             CronetBidirectionalStream.this, mResponseInfo, trailersBlock);
                 } catch (Exception e) {
                     onCallbackException(e);
                 }
             }
         });
     }
 
     @SuppressWarnings("unused")
     @CalledByNative
-    private void onError(
-            int errorCode, int nativeError, String errorString, long receivedBytesCount) {
+    private void onError(int errorCode, int nativeError, int nativeQuicError, String errorString,
+            long receivedBytesCount) {
         if (mResponseInfo != null) {
             mResponseInfo.setReceivedBytesCount(receivedBytesCount);
         }
-        failWithException(new CronetException(
-                "Exception in BidirectionalStream: " + errorString, errorCode, nativeError));
+        CronetException exception;
+        if (nativeError == NetError.ERR_QUIC_PROTOCOL_ERROR) {
+            // nativeQuicError here will always be 0 (QUIC_NO_ERROR), so this isn't useful yet.
+            // Adding it now anyway for uniformity with CronetUrlRequest.
+            // TODO(mgersh): plumb through the real QUIC error code

[pauljensen, 2016/06/30 17:35:12]

I'm not a fan of having a comment in one place talk about the impl in another
place.  These sorts of comments frequently are subject to code rot.  I'd prefer
removing these three lines.

[mgersh, 2016/06/30 22:55:53]

Done.

+            exception = new QuicException("Exception in BidirectionalStream: " + errorString,
+                    nativeError, nativeQuicError);
+        } else {
+            exception = new CronetException(
+                    "Exception in BidirectionalStream: " + errorString, errorCode, nativeError);
+        }
+        failWithException(exception);
     }
 
     /**
      * Called when request is canceled, no callbacks will be called afterwards.
      */
     @SuppressWarnings("unused")
     @CalledByNative
     private void onCanceled() {
         postTaskToExecutor(new Runnable() {
             public void run() {
@@ skipping 151 matching lines @@
     private native boolean nativeReadData(
             long nativePtr, ByteBuffer byteBuffer, int position, int limit);
 
     @NativeClassQualifiedName("CronetBidirectionalStreamAdapter")
     private native boolean nativeWritevData(long nativePtr, ByteBuffer[] buffers, int[] positions,
             int[] limits, boolean endOfStream);
 
     @NativeClassQualifiedName("CronetBidirectionalStreamAdapter")
     private native void nativeDestroy(long nativePtr, boolean sendOnCanceled);
 }