Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2069283002: milo: fix step duration (Closed)

Created:
4 years, 6 months ago by nodir
Modified:
4 years, 6 months ago
Reviewers:
dnj, estaab, hinoka
CC:
andrew.wang, chromium-reviews, infra-reviews+luci-go_chromium.org, M-A Ruel, tandrii+luci-go_chromium.org, todd
Base URL:
https://chromium.googlesource.com/external/github.com/luci/luci-go@master
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

milo: fix step duration annottee: support CURRENT_TIMESTAMP, which specifies build start time, build end time and time of the following annotation. milo: compute step duration from step start/end if availalbe. BUG=613584 Committed: https://github.com/luci/luci-go/commit/3f5844f8dddb36cd14bd3f050916f0aa7878aec8

Patch Set 1 #

Patch Set 2 : fixed Finished, duration and tests #

Patch Set 3 : gofmt #

Patch Set 4 : gofmt #

Total comments: 2

Patch Set 5 : simplify step duration computation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -69 lines) Patch
M appengine/cmd/milo/logdog/logDogBuild.go View 1 2 3 4 4 chunks +21 lines, -9 lines 0 comments Download
M appengine/cmd/milo/swarming/build.go View 1 chunk +1 line, -0 lines 0 comments Download
M appengine/cmd/milo/swarming/expectations/build-exception.json View 1 4 chunks +12 lines, -12 lines 0 comments Download
M appengine/cmd/milo/swarming/expectations/build-patch-failure.json View 1 5 chunks +15 lines, -15 lines 0 comments Download
M appengine/cmd/milo/swarming/expectations/build-timeout.json View 1 2 chunks +6 lines, -6 lines 0 comments Download
M appengine/cmd/milo/swarming/testdata/build-exception View 1 6 chunks +9 lines, -1 line 0 comments Download
M appengine/cmd/milo/swarming/testdata/build-patch-failure View 1 9 chunks +13 lines, -0 lines 0 comments Download
M appengine/cmd/milo/swarming/testdata/build-timeout View 1 3 chunks +10 lines, -0 lines 0 comments Download
M client/logdog/annotee/annotation/annotation.go View 1 2 3 14 chunks +72 lines, -22 lines 0 comments Download
M client/logdog/annotee/annotation/annotation_test.go View 2 chunks +4 lines, -2 lines 0 comments Download
A client/logdog/annotee/annotation/test_data/timestamps.annotations.txt View 1 chunk +23 lines, -0 lines 0 comments Download
A client/logdog/annotee/annotation/test_expectations/timestamps_steps.proto.txt View 1 chunk +12 lines, -0 lines 0 comments Download
A client/logdog/annotee/annotation/test_expectations/timestamps_steps_one.proto.txt View 1 chunk +11 lines, -0 lines 0 comments Download
A client/logdog/annotee/annotation/test_expectations/timestamps_steps_two.proto.txt View 1 chunk +11 lines, -0 lines 0 comments Download
M client/logdog/annotee/processor.go View 1 2 3 3 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
nodir
PTAL Deployed: https://865-1de81bd-tainted-nodir-dot-luci-milo.appspot.com/swarming/prod/2f6ed3d047a03a10
4 years, 6 months ago (2016-06-15 22:00:25 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069283002/1
4 years, 6 months ago (2016-06-15 22:12:29 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Luci-go Mac Tester on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Luci-go%20Mac%20Tester/builds/1204)
4 years, 6 months ago (2016-06-15 22:16:59 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069283002/40001
4 years, 6 months ago (2016-06-15 23:30:16 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Luci-go Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Luci-go%20Presubmit/builds/1244)
4 years, 6 months ago (2016-06-15 23:38:29 UTC) #10
estaab
lgtm https://codereview.chromium.org/2069283002/diff/60001/appengine/cmd/milo/logdog/logDogBuild.go File appengine/cmd/milo/logdog/logDogBuild.go (right): https://codereview.chromium.org/2069283002/diff/60001/appengine/cmd/milo/logdog/logDogBuild.go#newcode90 appengine/cmd/milo/logdog/logDogBuild.go:90: comp.Finished = ended.Format(time.RFC3339) if you add if asc.Status ...
4 years, 6 months ago (2016-06-16 00:48:53 UTC) #11
nodir
https://codereview.chromium.org/2069283002/diff/60001/appengine/cmd/milo/logdog/logDogBuild.go File appengine/cmd/milo/logdog/logDogBuild.go (right): https://codereview.chromium.org/2069283002/diff/60001/appengine/cmd/milo/logdog/logDogBuild.go#newcode90 appengine/cmd/milo/logdog/logDogBuild.go:90: comp.Finished = ended.Format(time.RFC3339) On 2016/06/16 00:48:53, estaab wrote: > ...
4 years, 6 months ago (2016-06-16 17:14:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069283002/80001
4 years, 6 months ago (2016-06-16 17:15:10 UTC) #15
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://github.com/luci/luci-go/commit/3f5844f8dddb36cd14bd3f050916f0aa7878aec8
4 years, 6 months ago (2016-06-16 17:30:51 UTC) #17
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 17:30:54 UTC) #18
Message was sent while issue was closed. 
CQ bit was unchecked

Powered by Google App Engine
This is Rietveld 408576698