Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 2069263003: MostVisitedSites cleanup: kill SuggestionsPtrVector (Closed)

Created:
4 years, 6 months ago by Marc Treib
Modified:
4 years, 6 months ago
Reviewers:
Bernhard Bauer, sfiera
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MostVisitedSites cleanup: kill SuggestionsPtrVector BUG=601734 Committed: https://crrev.com/24efd8f2b60ebd3018af428b64135215cde97c16 Cr-Commit-Position: refs/heads/master@{#400232}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -109 lines) Patch
M components/ntp_tiles/most_visited_sites.h View 1 2 chunks +10 lines, -17 lines 0 comments Download
M components/ntp_tiles/most_visited_sites.cc View 1 9 chunks +61 lines, -74 lines 0 comments Download
M components/ntp_tiles/most_visited_sites_unittest.cc View 1 1 chunk +16 lines, -18 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
Marc Treib
4 years, 6 months ago (2016-06-16 13:41:08 UTC) #3
sfiera
LGTM
4 years, 6 months ago (2016-06-16 14:14:18 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069263003/20001
4 years, 6 months ago (2016-06-16 14:14:59 UTC) #6
Marc Treib
+bauerb for approval
4 years, 6 months ago (2016-06-16 14:17:48 UTC) #8
Bernhard Bauer
lgtm
4 years, 6 months ago (2016-06-16 14:29:21 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-16 15:10:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069263003/20001
4 years, 6 months ago (2016-06-16 19:31:11 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-16 19:38:06 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-16 19:38:20 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 19:39:59 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/24efd8f2b60ebd3018af428b64135215cde97c16
Cr-Commit-Position: refs/heads/master@{#400232}

Powered by Google App Engine
This is Rietveld 408576698