Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 20692002: Lazy call to custom stack trace formatting using Error.prepareStackTrace. (Closed)

Created:
7 years, 5 months ago by Yang
Modified:
7 years, 5 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Lazy call to custom stack trace formatting using Error.prepareStackTrace. This enables custom stack trace formatting for stack overflow. A consequence is that stack trace formatting is now easily observable, but we already established that the default stack trace formatting can be observed anyways. It is only triggered by the .stack getter, and it has to be explicitly called, (e.g. not implicitly after GC). R=mstarzinger@chromium.org BUG=v8:2559 Committed: https://code.google.com/p/v8/source/detail?r=15902

Patch Set 1 #

Total comments: 1

Patch Set 2 : comments addressed #

Patch Set 3 : adapting one test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -38 lines) Patch
M src/messages.js View 1 5 chunks +22 lines, -22 lines 0 comments Download
M test/mjsunit/stack-traces.js View 1 2 2 chunks +6 lines, -2 lines 0 comments Download
A + test/mjsunit/stack-traces-custom-lazy.js View 1 chunk +17 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
7 years, 5 months ago (2013-07-26 09:06:55 UTC) #1
Michael Starzinger
LGTM with a nit. https://codereview.chromium.org/20692002/diff/1/src/messages.js File src/messages.js (right): https://codereview.chromium.org/20692002/diff/1/src/messages.js#newcode1081 src/messages.js:1081: //Flag to prevent recursive call ...
7 years, 5 months ago (2013-07-26 09:12:58 UTC) #2
Yang
7 years, 5 months ago (2013-07-26 11:28:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r15902 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698