Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp

Issue 2069143002: Limit the number of accelerated canvases that can exist in a render process (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix layout test Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp
diff --git a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp
index e048949b7c0ed9e3165c1e5591e83629492bbbd8..fa666b06694c1a84005d98715eaf95ab254dd77f 100644
--- a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp
+++ b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp
@@ -80,6 +80,7 @@ protected:
HTMLCanvasElement& canvasElement() const { return *m_canvasElement; }
CanvasRenderingContext2D* context2d() const { return static_cast<CanvasRenderingContext2D*>(canvasElement().renderingContext()); }
intptr_t getGlobalGPUMemoryUsage() const { return ImageBuffer::getGlobalGPUMemoryUsage(); }
+ unsigned getGlobalAcceleratedImageBufferCount() const { return ImageBuffer::getGlobalAcceleratedImageBufferCount(); }
intptr_t getCurrentGPUMemoryUsage() const { return canvasElement().buffer()->getGPUMemoryUsage(); }
void createContext(OpacityMode);
@@ -690,33 +691,39 @@ TEST_F(CanvasRenderingContext2DTest, GPUMemoryUpdateForAcceleratedCanvas)
// and 2 is an estimate of num of gpu buffers required
EXPECT_EQ(800, getCurrentGPUMemoryUsage());
EXPECT_EQ(800, getGlobalGPUMemoryUsage());
+ EXPECT_EQ(1u, getGlobalAcceleratedImageBufferCount());
// Switching accelerated mode to non-accelerated mode
fakeAccelerateSurfacePtr->setIsAccelerated(false);
canvasElement().buffer()->updateGPUMemoryUsage();
EXPECT_EQ(0, getCurrentGPUMemoryUsage());
EXPECT_EQ(0, getGlobalGPUMemoryUsage());
+ EXPECT_EQ(0u, getGlobalAcceleratedImageBufferCount());
// Switching non-accelerated mode to accelerated mode
fakeAccelerateSurfacePtr->setIsAccelerated(true);
canvasElement().buffer()->updateGPUMemoryUsage();
EXPECT_EQ(800, getCurrentGPUMemoryUsage());
EXPECT_EQ(800, getGlobalGPUMemoryUsage());
+ EXPECT_EQ(1u, getGlobalAcceleratedImageBufferCount());
// Creating a different accelerated image buffer
OwnPtr<FakeAcceleratedImageBufferSurfaceForTesting> fakeAccelerateSurface2 = adoptPtr(new FakeAcceleratedImageBufferSurfaceForTesting(IntSize(10, 5), NonOpaque));
OwnPtr<ImageBuffer> imageBuffer2 = ImageBuffer::create(std::move(fakeAccelerateSurface2));
EXPECT_EQ(800, getCurrentGPUMemoryUsage());
EXPECT_EQ(1200, getGlobalGPUMemoryUsage());
+ EXPECT_EQ(2u, getGlobalAcceleratedImageBufferCount());
// Tear down the first image buffer that resides in current canvas element
canvasElement().setSize(IntSize(20, 20));
Mock::VerifyAndClearExpectations(fakeAccelerateSurfacePtr);
EXPECT_EQ(400, getGlobalGPUMemoryUsage());
+ EXPECT_EQ(1u, getGlobalAcceleratedImageBufferCount());
// Tear down the second image buffer
imageBuffer2.reset();
EXPECT_EQ(0, getGlobalGPUMemoryUsage());
+ EXPECT_EQ(0u, getGlobalAcceleratedImageBufferCount());
}
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp ('k') | third_party/WebKit/Source/platform/graphics/ImageBuffer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698