Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Issue 2069133005: [devil] Add signal handler context manager. (Closed)

Created:
4 years, 6 months ago by jbudorick
Modified:
4 years, 6 months ago
CC:
catapult-reviews_chromium.org
Base URL:
git@github.com:catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : mikecase comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
A devil/devil/utils/signal_handler.py View 1 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
jbudorick
4 years, 6 months ago (2016-06-16 18:23:19 UTC) #2
mikecase (wrong mikecase)
lgtm, very cool https://codereview.chromium.org/2069133005/diff/1/devil/devil/utils/signal_handler.py File devil/devil/utils/signal_handler.py (right): https://codereview.chromium.org/2069133005/diff/1/devil/devil/utils/signal_handler.py#newcode22 devil/devil/utils/signal_handler.py:22: def handler(n, f): would prefer if ...
4 years, 6 months ago (2016-06-16 19:05:07 UTC) #4
jbudorick
https://codereview.chromium.org/2069133005/diff/1/devil/devil/utils/signal_handler.py File devil/devil/utils/signal_handler.py (right): https://codereview.chromium.org/2069133005/diff/1/devil/devil/utils/signal_handler.py#newcode22 devil/devil/utils/signal_handler.py:22: def handler(n, f): On 2016/06/16 19:05:07, mikecase (wrong mikecase) ...
4 years, 6 months ago (2016-06-16 19:20:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069133005/20001
4 years, 6 months ago (2016-06-16 19:20:37 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 19:43:37 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698