ui/views/cocoa/bridged_native_widget.h - Issue 2069103004: MacViews: Attach child windows when parent is on the screen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/cocoa/bridged_native_widget.h

Issue 2069103004: MacViews: Attach child windows when parent is on the screen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed OnVisibilityChangedTo(). Added test. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/cocoa/bridged_native_widget.h

diff --git a/ui/views/cocoa/bridged_native_widget.h b/ui/views/cocoa/bridged_native_widget.h

index 1b2607cf94d146acef27a193d419b849d488c171..769b886e03708cca073741af533d5ad7ea82e0a7 100644

--- a/ui/views/cocoa/bridged_native_widget.h

+++ b/ui/views/cocoa/bridged_native_widget.h

@@ -131,10 +131,6 @@ class VIEWS_EXPORT BridgedNativeWidget

// being reordered in (or out of) the screen list.

void OnVisibilityChanged();

- // Explicitly set the visibility. This is called when Cocoa requests a draw,

- // but hasn't updated the value of -[NSWindow isVisible] yet.

- void OnVisibilityChangedTo(bool new_visibility);

// Called by the NSWindowDelegate on a scale factor or color space change.

void OnBackingPropertiesChanged();

« no previous file with comments | « no previous file | ui/views/cocoa/bridged_native_widget.mm » ('j') | ui/views/widget/native_widget_mac_unittest.mm » ('J')