Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 20691002: Rebaseline webkit test with correct assumptions. (Closed)

Created:
7 years, 5 months ago by Michael Achenbach
Modified:
7 years, 5 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Rebaseline webkit test with correct assumptions. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15901

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M test/webkit/fast/js/stack-overflow-arrity-catch.js View 3 chunks +4 lines, -2 lines 0 comments Download
M test/webkit/fast/js/stack-overflow-arrity-catch-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
PTAL
7 years, 5 months ago (2013-07-26 09:05:14 UTC) #1
Sven Panne
LGTM, although it is totally unclear what the test is actually trying to test. I ...
7 years, 5 months ago (2013-07-26 10:45:47 UTC) #2
Michael Achenbach
7 years, 5 months ago (2013-07-26 11:22:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15901 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698