Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: tools/clang/blink_gc_plugin/TracingStatus.h

Issue 2068983003: Revert of GC plugin: improve error reporting when tracing illegal fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/TracingStatus.h
diff --git a/tools/clang/blink_gc_plugin/TracingStatus.h b/tools/clang/blink_gc_plugin/TracingStatus.h
index 46e96547a9d4fa79c27ec4f11b77749a6c6d2931..9eb1080de85d13845a910530b559d739883ebe6b 100644
--- a/tools/clang/blink_gc_plugin/TracingStatus.h
+++ b/tools/clang/blink_gc_plugin/TracingStatus.h
@@ -5,33 +5,12 @@
#ifndef TOOLS_BLINK_GC_PLUGIN_TRACING_STATUS_H_
#define TOOLS_BLINK_GC_PLUGIN_TRACING_STATUS_H_
-// TracingStatus is a four-point value ordered by
-// illegal < unneeded < unknown < needed
-//
-// It is used to categorize tracing of fields:
-//
-// * illegal field is invalid/illegal to trace.
-// * unneeded field has type with no traceable fields of its own;
-// it may have an empty trace() method. Not harmful
-// to trace, but not needed.
-// * unknown initial TracingStatus value.
-// * needed field is a heap reference or an object containing
-// traceable fields.
-//
-// Tracing status |illegal| is considered an error; treating |unneeded| also
-// as an error would detect and report unnecessary tracing of objects that
-// probably don't need to be on the Blink GC heap. However, template use
-// and instantiation can leave us with classes that do have empty trace
-// methods and no traceable fields -- reporting these as errors/warnings
-// wouldn't work. Hence, only consider |illegal| as an error TracingStatus
-// state.
+// TracingStatus is a three-point value ordered by unneeded < unknown < needed.
class TracingStatus {
public:
- static TracingStatus Illegal() { return kIllegal; }
static TracingStatus Unneeded() { return kUnneeded; }
static TracingStatus Unknown() { return kUnknown; }
static TracingStatus Needed() { return kNeeded; }
- bool IsIllegal() const { return status_ == kIllegal; }
bool IsUnneeded() const { return status_ == kUnneeded; }
bool IsUnknown() const { return status_ == kUnknown; }
bool IsNeeded() const { return status_ == kNeeded; }
@@ -42,7 +21,7 @@
return status_ == other.status_;
}
private:
- enum Status { kIllegal, kUnneeded, kUnknown, kNeeded };
+ enum Status { kUnneeded, kUnknown, kNeeded };
TracingStatus(Status status) : status_(status) {}
Status status_;
};
« no previous file with comments | « tools/clang/blink_gc_plugin/RecordInfo.cpp ('k') | tools/clang/blink_gc_plugin/tests/fields_illegal_tracing.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698