Chromium Code Reviews

Unified Diff: tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp

Issue 2068983003: Revert of GC plugin: improve error reporting when tracing illegal fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « no previous file | tools/clang/blink_gc_plugin/CheckFieldsVisitor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp
diff --git a/tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp b/tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp
index ca6bb18a04ab467dce61120d7b8c773bccdb2236..1a32defcc42698ae7c32cf92dc3264dcc9c7d66e 100644
--- a/tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp
+++ b/tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp
@@ -68,7 +68,6 @@
: instance_(instance),
reporter_(instance),
options_(options),
- cache_(instance),
json_(0) {
// Only check structures in the blink and WebKit namespaces.
options_.checked_namespaces.insert("blink");
@@ -553,10 +552,9 @@
reporter_.BaseRequiresTracing(parent, trace, base.first);
for (auto& field : parent->GetFields()) {
- if (!field.second.IsProperlyTraced() ||
- field.second.IsInproperlyTraced()) {
- // Report one or more tracing-related field errors.
- reporter_.FieldsImproperlyTraced(parent, trace);
+ if (!field.second.IsProperlyTraced()) {
+ // Discontinue once an untraced-field error is found.
+ reporter_.FieldsRequireTracing(parent, trace);
break;
}
}
@@ -592,7 +590,6 @@
"reference" : "raw") :
Parent()->IsRefPtr() ? "ref" :
Parent()->IsOwnPtr() ? "own" :
- Parent()->IsUniquePtr() ? "unique" :
(Parent()->IsMember() || Parent()->IsWeakMember()) ? "mem" :
"val");
json_->CloseObject();
« no previous file with comments | « no previous file | tools/clang/blink_gc_plugin/CheckFieldsVisitor.h » ('j') | no next file with comments »

Powered by Google App Engine