| OLD | NEW |
| 1 // Copyright 2015 The Chromium Authors. All rights reserved. | 1 // Copyright 2015 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #ifndef TOOLS_BLINK_GC_PLUGIN_CHECK_FIELDS_VISITOR_H_ | 5 #ifndef TOOLS_BLINK_GC_PLUGIN_CHECK_FIELDS_VISITOR_H_ |
| 6 #define TOOLS_BLINK_GC_PLUGIN_CHECK_FIELDS_VISITOR_H_ | 6 #define TOOLS_BLINK_GC_PLUGIN_CHECK_FIELDS_VISITOR_H_ |
| 7 | 7 |
| 8 #include <vector> | 8 #include <vector> |
| 9 | 9 |
| 10 #include "Edge.h" | 10 #include "Edge.h" |
| 11 | 11 |
| 12 struct BlinkGCPluginOptions; | 12 struct BlinkGCPluginOptions; |
| 13 class FieldPoint; | 13 class FieldPoint; |
| 14 | 14 |
| 15 // This visitor checks that the fields of a class are "well formed". | 15 // This visitor checks that the fields of a class are "well formed". |
| 16 // - OwnPtr and RefPtr must not point to a GC derived type. | 16 // - OwnPtr and RefPtr must not point to a GC derived type. |
| 17 // - Part objects must not be a GC derived type. | 17 // - Part objects must not be a GC derived type. |
| 18 // - An on-heap class must never contain GC roots. | 18 // - An on-heap class must never contain GC roots. |
| 19 // - Only stack-allocated types may point to stack-allocated types. | 19 // - Only stack-allocated types may point to stack-allocated types. |
| 20 | 20 |
| 21 class CheckFieldsVisitor : public RecursiveEdgeVisitor { | 21 class CheckFieldsVisitor : public RecursiveEdgeVisitor { |
| 22 public: | 22 public: |
| 23 enum Error { | 23 enum Error { |
| 24 kRawPtrToGCManaged, | 24 kRawPtrToGCManaged, |
| 25 kRefPtrToGCManaged, | 25 kRefPtrToGCManaged, |
| 26 kReferencePtrToGCManaged, | 26 kReferencePtrToGCManaged, |
| 27 kOwnPtrToGCManaged, | 27 kOwnPtrToGCManaged, |
| 28 kUniquePtrToGCManaged, | |
| 29 kMemberToGCUnmanaged, | 28 kMemberToGCUnmanaged, |
| 30 kMemberInUnmanaged, | 29 kMemberInUnmanaged, |
| 31 kPtrFromHeapToStack, | 30 kPtrFromHeapToStack, |
| 32 kGCDerivedPartObject | 31 kGCDerivedPartObject |
| 33 }; | 32 }; |
| 34 | 33 |
| 35 using Errors = std::vector<std::pair<FieldPoint*, Error>>; | 34 using Errors = std::vector<std::pair<FieldPoint*, Error>>; |
| 36 | 35 |
| 37 CheckFieldsVisitor(); | 36 CheckFieldsVisitor(); |
| 38 | 37 |
| 39 Errors& invalid_fields(); | 38 Errors& invalid_fields(); |
| 40 | 39 |
| 41 bool ContainsInvalidFields(RecordInfo* info); | 40 bool ContainsInvalidFields(RecordInfo* info); |
| 42 | 41 |
| 43 void AtMember(Member* edge) override; | 42 void AtMember(Member* edge) override; |
| 44 void AtValue(Value* edge) override; | 43 void AtValue(Value* edge) override; |
| 45 void AtCollection(Collection* edge) override; | 44 void AtCollection(Collection* edge) override; |
| 46 | 45 |
| 47 private: | 46 private: |
| 48 Error InvalidSmartPtr(Edge* ptr); | 47 Error InvalidSmartPtr(Edge* ptr); |
| 49 | 48 |
| 50 FieldPoint* current_; | 49 FieldPoint* current_; |
| 51 bool stack_allocated_host_; | 50 bool stack_allocated_host_; |
| 52 bool managed_host_; | 51 bool managed_host_; |
| 53 Errors invalid_fields_; | 52 Errors invalid_fields_; |
| 54 }; | 53 }; |
| 55 | 54 |
| 56 #endif // TOOLS_BLINK_GC_PLUGIN_CHECK_FIELDS_VISITOR_H_ | 55 #endif // TOOLS_BLINK_GC_PLUGIN_CHECK_FIELDS_VISITOR_H_ |
| OLD | NEW |