Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 2068953003: Revert of Clear the login webview when SAML flow is canceled (Closed)

Created:
4 years, 6 months ago by jdufault
Modified:
4 years, 6 months ago
Reviewers:
afakhry, xiyuan, achuithb, emaxx
CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Clear the login webview when SAML flow is canceled (patchset #8 id:140001 of https://codereview.chromium.org/1988113004/ ) Reason for revert: Makes SAMLPolicyTest.SAMLInterstitialNext extremely flaky. See crbug.com/620353. Original issue's description: > Clear the login webview when SAML flow is canceled > > Previously, the SAML webview running third-party website was kept > running in the background even after the SAML login flow is > canceled. > > This CL adds a redirection of the SAML webview to a blank page > each time the login screen mode is changed. > > BUG=613245 > TEST=existing login tests, manual testing with going to camera-capturing > SAML web page and checking that the camera lid is off once the SAML flow > is canceled manually or terminated due to a timeout or canceled due to > network disconnection > > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation > > Committed: https://crrev.com/9ac3388d7cb865125b9af3c4e562a9677412e206 > Cr-Commit-Position: refs/heads/master@{#399769} TBR=achuith@chromium.org,afakhry@chromium.org,xiyuan@chromium.org,emaxx@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=613245 Committed: https://crrev.com/c6a537d7c1244a6892de34d80cf564c97270f21e Cr-Commit-Position: refs/heads/master@{#399923}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -22 lines) Patch
M chrome/browser/resources/chromeos/login/screen_gaia_signin.js View 2 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/resources/gaia_auth_host/authenticator.js View 6 chunks +4 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
jdufault
Created Revert of Clear the login webview when SAML flow is canceled
4 years, 6 months ago (2016-06-15 16:36:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068953003/1
4 years, 6 months ago (2016-06-15 16:36:58 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-15 16:37:42 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 16:39:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c6a537d7c1244a6892de34d80cf564c97270f21e
Cr-Commit-Position: refs/heads/master@{#399923}

Powered by Google App Engine
This is Rietveld 408576698