Chromium Code Reviews
DescriptionRevert of Clear the login webview when SAML flow is canceled (patchset #8 id:140001 of https://codereview.chromium.org/1988113004/ )
Reason for revert:
Makes SAMLPolicyTest.SAMLInterstitialNext extremely flaky. See crbug.com/620353.
Original issue's description:
> Clear the login webview when SAML flow is canceled
>
> Previously, the SAML webview running third-party website was kept
> running in the background even after the SAML login flow is
> canceled.
>
> This CL adds a redirection of the SAML webview to a blank page
> each time the login screen mode is changed.
>
> BUG=613245
> TEST=existing login tests, manual testing with going to camera-capturing
> SAML web page and checking that the camera lid is off once the SAML flow
> is canceled manually or terminated due to a timeout or canceled due to
> network disconnection
>
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
>
> Committed: https://crrev.com/9ac3388d7cb865125b9af3c4e562a9677412e206
> Cr-Commit-Position: refs/heads/master@{#399769}
TBR=achuith@chromium.org,afakhry@chromium.org,xiyuan@chromium.org,emaxx@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=613245
Committed: https://crrev.com/c6a537d7c1244a6892de34d80cf564c97270f21e
Cr-Commit-Position: refs/heads/master@{#399923}
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|
||||||||||||||||||||||||||||