Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2068953002: Turn flag opt-in-ime-menu on by default. (Closed)

Created:
4 years, 6 months ago by Azure Wei
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Turn flag: opt-in-ime-menu on by default, which aims to launch on M53. BUG=570761 TEST=Verified on local build. Committed: https://crrev.com/8a07498f562fc6bab382e01b5e711421fa30ef72 Cr-Commit-Position: refs/heads/master@{#400374}

Patch Set 1 #

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/common/chrome_features.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 32 (16 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068953002/1
4 years, 6 months ago (2016-06-15 00:52:23 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_android on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/81522)
4 years, 6 months ago (2016-06-15 01:07:49 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068953002/1
4 years, 6 months ago (2016-06-15 03:07:11 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-15 03:47:13 UTC) #8
Azure Wei
Hi thestig@, please review this cl. Thanks!
4 years, 6 months ago (2016-06-15 04:27:12 UTC) #11
Lei Zhang
lgtm Please make sure you finish the launch review, or revert this before it reaches ...
4 years, 6 months ago (2016-06-15 22:36:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068953002/1
4 years, 6 months ago (2016-06-16 23:37:14 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-generic_chromium_compile_only_ng/builds/154272)
4 years, 6 months ago (2016-06-16 23:56:31 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068953002/1
4 years, 6 months ago (2016-06-17 00:21:36 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/154340) chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 6 months ago (2016-06-17 00:37:59 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068953002/1
4 years, 6 months ago (2016-06-17 01:02:39 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/154372)
4 years, 6 months ago (2016-06-17 01:17:32 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068953002/20001
4 years, 6 months ago (2016-06-17 05:33:31 UTC) #27
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-17 06:16:50 UTC) #29
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/8a07498f562fc6bab382e01b5e711421fa30ef72 Cr-Commit-Position: refs/heads/master@{#400374}
4 years, 6 months ago (2016-06-17 06:18:43 UTC) #31
Azure Wei
4 years, 5 months ago (2016-07-07 01:54:51 UTC) #32
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2123363003/ by azurewei@chromium.org.

The reason for reverting is: This feature will not be launched in M53..

Powered by Google App Engine
This is Rietveld 408576698