|
|
Chromium Code Reviews
DescriptionTurn flag: opt-in-ime-menu on by default, which aims to launch on M53.
BUG=570761
TEST=Verified on local build.
Committed: https://crrev.com/8a07498f562fc6bab382e01b5e711421fa30ef72
Cr-Commit-Position: refs/heads/master@{#400374}
Patch Set 1 #Patch Set 2 #
Messages
Total messages: 32 (16 generated)
The CQ bit was checked by azurewei@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068953002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_android on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
The CQ bit was checked by azurewei@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068953002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Turn on opt-in-ime-menu flag by default. BUG=570761 TEST=Verified on local build. ========== to ========== Turn flag: opt-in-ime-menu on by default, which aims to launch on M53. BUG=570761 TEST=Verified on local build. ==========
azurewei@chromium.org changed reviewers: + thestig@chromium.org
Hi thestig@, please review this cl. Thanks!
lgtm Please make sure you finish the launch review, or revert this before it reaches stable.
The CQ bit was checked by azurewei@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068953002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
The CQ bit was checked by azurewei@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068953002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
The CQ bit was checked by azurewei@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068953002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
The CQ bit was checked by azurewei@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org Link to the patchset: https://codereview.chromium.org/2068953002/#ps20001 (title: "")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068953002/20001
Message was sent while issue was closed.
Description was changed from ========== Turn flag: opt-in-ime-menu on by default, which aims to launch on M53. BUG=570761 TEST=Verified on local build. ========== to ========== Turn flag: opt-in-ime-menu on by default, which aims to launch on M53. BUG=570761 TEST=Verified on local build. ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Turn flag: opt-in-ime-menu on by default, which aims to launch on M53. BUG=570761 TEST=Verified on local build. ========== to ========== Turn flag: opt-in-ime-menu on by default, which aims to launch on M53. BUG=570761 TEST=Verified on local build. Committed: https://crrev.com/8a07498f562fc6bab382e01b5e711421fa30ef72 Cr-Commit-Position: refs/heads/master@{#400374} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/8a07498f562fc6bab382e01b5e711421fa30ef72 Cr-Commit-Position: refs/heads/master@{#400374}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2123363003/ by azurewei@chromium.org. The reason for reverting is: This feature will not be launched in M53.. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
