Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2068893003: Share more code in ARC_TO/R_ARC_TO (Closed)

Created:
4 years, 6 months ago by Evan Stade
Modified:
4 years, 6 months ago
Reviewers:
tdanderson
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Share more code in ARC_TO/R_ARC_TO BUG=620345 Committed: https://crrev.com/56b7f3ae8d0c4e53cbb7f24377ddd94c55558323 Cr-Commit-Position: refs/heads/master@{#400010}

Patch Set 1 #

Patch Set 2 : inline #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -17 lines) Patch
M ui/gfx/paint_vector_icon.cc View 1 2 chunks +9 lines, -17 lines 2 comments Download

Messages

Total messages: 8 (3 generated)
Evan Stade
here's what i had in mind, wdyt? https://codereview.chromium.org/2068893003/diff/20001/ui/gfx/paint_vector_icon.cc File ui/gfx/paint_vector_icon.cc (right): https://codereview.chromium.org/2068893003/diff/20001/ui/gfx/paint_vector_icon.cc#newcode162 ui/gfx/paint_vector_icon.cc:162: ? static_cast<void ...
4 years, 6 months ago (2016-06-15 18:51:37 UTC) #2
tdanderson
lgtm, thanks for poaching this! https://codereview.chromium.org/2068893003/diff/20001/ui/gfx/paint_vector_icon.cc File ui/gfx/paint_vector_icon.cc (right): https://codereview.chromium.org/2068893003/diff/20001/ui/gfx/paint_vector_icon.cc#newcode162 ui/gfx/paint_vector_icon.cc:162: ? static_cast<void (SkPath::*)( On ...
4 years, 6 months ago (2016-06-15 19:23:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068893003/20001
4 years, 6 months ago (2016-06-15 20:17:27 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-15 21:13:28 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 21:15:12 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/56b7f3ae8d0c4e53cbb7f24377ddd94c55558323
Cr-Commit-Position: refs/heads/master@{#400010}

Powered by Google App Engine
This is Rietveld 408576698