Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2068883003: Update size of Google Logo on Android NTP. (Closed)

Created:
4 years, 6 months ago by Bernhard Bauer
Modified:
4 years, 6 months ago
Reviewers:
Ted C, Ian Wen, dgn
CC:
chromium-reviews, zine-eng+reviews_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update size of Google Logo on Android NTP. The logo is now 64dp high on <600dp screens, and 96dp on bigger screens. Because the default logo is never upscaled, using smaller assets while keeping the size of the view the same works, and ensures Doodles will not get downscaled. Screenshots on tablet/phone: https://imgur.com/a/ntrQj BUG=612156 Committed: https://crrev.com/fb7d5e9e3633a8df4fca421c1d0ddefa6d1c2a4e Cr-Commit-Position: refs/heads/master@{#400769}

Patch Set 1 #

Patch Set 2 : review #

Messages

Total messages: 25 (9 generated)
Bernhard Bauer
Please review. Thanks!
4 years, 6 months ago (2016-06-15 17:30:23 UTC) #3
Ted C
On 2016/06/15 17:30:23, Bernhard Bauer wrote: > Please review. Thanks! Vector drawables are not supported ...
4 years, 6 months ago (2016-06-15 20:05:57 UTC) #4
Bernhard Bauer
On Wed, Jun 15, 2016, 21:05 <tedchoc@chromium.org> wrote: > On 2016/06/15 17:30:23, Bernhard Bauer wrote: ...
4 years, 6 months ago (2016-06-15 20:27:29 UTC) #5
Ian Wen
If you do a quick test for vector drawable compat, it might work. Yet no ...
4 years, 6 months ago (2016-06-15 20:39:51 UTC) #7
Bernhard Bauer
On 2016/06/15 20:39:51, Ian Wen wrote: > If you do a quick test for vector ...
4 years, 6 months ago (2016-06-15 21:22:53 UTC) #8
Ian Wen
On 2016/06/15 21:22:53, Bernhard Bauer wrote: > On 2016/06/15 20:39:51, Ian Wen wrote: > > ...
4 years, 6 months ago (2016-06-15 21:36:33 UTC) #9
Bernhard Bauer
On 2016/06/15 21:36:33, Ian Wen wrote: > On 2016/06/15 21:22:53, Bernhard Bauer wrote: > > ...
4 years, 6 months ago (2016-06-16 14:26:47 UTC) #10
Ted C
On 2016/06/16 14:26:47, Bernhard Bauer wrote: > On 2016/06/15 21:36:33, Ian Wen wrote: > > ...
4 years, 6 months ago (2016-06-16 17:08:32 UTC) #11
Bernhard Bauer
On 2016/06/16 17:08:32, Ted C wrote: > On 2016/06/16 14:26:47, Bernhard Bauer wrote: > > ...
4 years, 6 months ago (2016-06-16 20:11:09 UTC) #12
Bernhard Bauer
OK, I've reverted back to bitmap drawables for this CL while I investigate the performance ...
4 years, 6 months ago (2016-06-17 12:40:48 UTC) #13
Bernhard Bauer
On 2016/06/17 12:40:48, Bernhard Bauer wrote: > OK, I've reverted back to bitmap drawables for ...
4 years, 6 months ago (2016-06-20 17:35:48 UTC) #15
Ted C
lgtm Sorry about that! Did the tablet logos get slightly bigger with this change? Also, ...
4 years, 6 months ago (2016-06-20 18:10:04 UTC) #16
Bernhard Bauer
On 2016/06/20 18:10:04, Ted C wrote: > lgtm > > Sorry about that! Did the ...
4 years, 6 months ago (2016-06-20 19:51:01 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068883003/20001
4 years, 6 months ago (2016-06-20 19:51:45 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-20 20:34:26 UTC) #23
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 20:41:14 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fb7d5e9e3633a8df4fca421c1d0ddefa6d1c2a4e
Cr-Commit-Position: refs/heads/master@{#400769}

Powered by Google App Engine
This is Rietveld 408576698