src/views/mac/SkNSView.mm - Issue 2068863002: Added warning for variable-length arrays to GYP

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/views/mac/SkNSView.mm

Issue 2068863002: Added warning for variable-length arrays to GYP (Closed) Base URL: https://skia.googlesource.com/skia@master

Patch Set: Made array size variable 'const' in file triggering -Wvla Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/views/mac/SkNSView.mm

diff --git a/src/views/mac/SkNSView.mm b/src/views/mac/SkNSView.mm

index 3a096f684a026ac6c9ba27fc6d91a09dc06dbab0..73b353f15d77c8d512d1f38e683317fae12d4dfc 100644

--- a/src/views/mac/SkNSView.mm

+++ b/src/views/mac/SkNSView.mm

@@ -344,7 +344,7 @@ static CGLContextObj createGLContext(int msaaSampleCount) {

CGLPixelFormatObj format;

GLint npix = 0;

if (msaaSampleCount > 0) {

- static int kAttributeCount = SK_ARRAY_COUNT(attributes);

+ static const int kAttributeCount = SK_ARRAY_COUNT(attributes);

CGLPixelFormatAttribute msaaAttributes[kAttributeCount + 5];

memcpy(msaaAttributes, attributes, sizeof(attributes));

SkASSERT(0 == msaaAttributes[kAttributeCount - 1]);

« no previous file with comments | « gyp/common_conditions.gypi ('k') | no next file » | no next file with comments »