gyp/common_conditions.gypi - Issue 2068863002: Added warning for variable-length arrays to GYP

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gyp/common_conditions.gypi

Issue 2068863002: Added warning for variable-length arrays to GYP (Closed) Base URL: https://skia.googlesource.com/skia@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gyp/common_conditions.gypi

diff --git a/gyp/common_conditions.gypi b/gyp/common_conditions.gypi

index b4b98902633fb83972c004697846ed1154a96a10..c733833d549a1fb01063558946df41627bb578fa 100644

--- a/gyp/common_conditions.gypi

+++ b/gyp/common_conditions.gypi

@@ -246,6 +246,7 @@

'-Wsign-compare',

'-Wno-unused-parameter',

+ '-Wvla',

mtklein 2016/06/15 14:43:27 You might want to have these match the indentation

dvonbeck 2016/06/15 14:59:03 Oops I didn't notice. Done!

'cflags_cc': [

'-std=c++11',

@@ -561,6 +562,7 @@

'-Winit-self',

'-Wpointer-arith',

'-Wsign-compare',

+ '-Wvla',

'-Wno-unused-parameter',

« no previous file with comments | « no previous file | no next file » | no next file with comments »