base/task_scheduler/sequence.h - Issue 2068853002: Rename SchedulerThreadPool* to SchedulerWorkerPool*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/task_scheduler/sequence.h

Issue 2068853002: Rename SchedulerThreadPool* to SchedulerWorkerPool* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rename1

Patch Set: CR Feedback fdoray@ Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/task_scheduler/sequence.h

diff --git a/base/task_scheduler/sequence.h b/base/task_scheduler/sequence.h

index 37cb8d5b9aa7f7dd50a8a406ebe9cc67aea91fed..a2791d4f9fe68929933ebae637453f65de51fb04 100644

--- a/base/task_scheduler/sequence.h

+++ b/base/task_scheduler/sequence.h

@@ -27,7 +27,7 @@ namespace internal {

// architecture: Sequence -> Task -> TaskRunner -> Sequence -> ...

// This is okay so long as the other owners of Sequence (PriorityQueue and

// SchedulerWorkerThread in alternance and

-// SchedulerThreadPoolImpl::SchedulerWorkerThreadDelegateImpl::GetWork()

+// SchedulerWorkerPoolImpl::SchedulerWorkerThreadDelegateImpl::GetWork()

// temporarily) keep running it (and taking Tasks from it as a result). A

// dangling reference cycle would only occur should they release their reference

// to it while it's not empty. In other words, it is only correct for them to

« no previous file with comments | « base/task_scheduler/scheduler_worker_pool_impl_unittest.cc ('k') | base/task_scheduler/task_scheduler_impl.h » ('j') | no next file with comments »