Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2068853002: Rename SchedulerThreadPool* to SchedulerWorkerPool* (Closed)

Created:
4 years, 6 months ago by robliao
Modified:
4 years, 6 months ago
Reviewers:
danakj, gab, fdoray
CC:
chromium-reviews, gab+watch_chromium.org, robliao+watch_chromium.org, fdoray+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@rename1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename SchedulerThreadPool* to SchedulerWorkerPool* This rename is in preparation for virtualized Scheduler Workers. BUG=553459 Committed: https://crrev.com/624260a841365547b5687ecb14de7fe09fe01c9c Cr-Commit-Position: refs/heads/master@{#401351}

Patch Set 1 #

Patch Set 2 : Rename SchedulerThreadPool* to SchedulerWorkerPool* #

Total comments: 2

Patch Set 3 : CR Feedback fdoray@ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -1441 lines) Patch
M base/BUILD.gn View 1 2 chunks +4 lines, -4 lines 0 comments Download
M base/base.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M base/base.gypi View 1 1 chunk +3 lines, -3 lines 0 comments Download
M base/task_scheduler/delayed_task_manager.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M base/task_scheduler/delayed_task_manager.cc View 1 6 chunks +9 lines, -9 lines 0 comments Download
M base/task_scheduler/delayed_task_manager_unittest.cc View 1 11 chunks +21 lines, -21 lines 0 comments Download
M base/task_scheduler/scheduler_service_thread_unittest.cc View 1 2 7 chunks +12 lines, -12 lines 0 comments Download
D base/task_scheduler/scheduler_thread_pool.h View 1 1 chunk +0 lines, -67 lines 0 comments Download
D base/task_scheduler/scheduler_thread_pool_impl.h View 1 chunk +0 lines, -164 lines 0 comments Download
D base/task_scheduler/scheduler_thread_pool_impl.cc View 1 chunk +0 lines, -565 lines 0 comments Download
D base/task_scheduler/scheduler_thread_pool_impl_unittest.cc View 1 chunk +0 lines, -388 lines 0 comments Download
A + base/task_scheduler/scheduler_worker_pool.h View 1 3 chunks +13 lines, -13 lines 0 comments Download
A + base/task_scheduler/scheduler_worker_pool_impl.h View 1 9 chunks +31 lines, -31 lines 0 comments Download
A + base/task_scheduler/scheduler_worker_pool_impl.cc View 1 30 chunks +59 lines, -59 lines 0 comments Download
A + base/task_scheduler/scheduler_worker_pool_impl_unittest.cc View 1 15 chunks +61 lines, -61 lines 0 comments Download
M base/task_scheduler/sequence.h View 1 1 chunk +1 line, -1 line 0 comments Download
M base/task_scheduler/task_scheduler_impl.h View 1 3 chunks +11 lines, -11 lines 0 comments Download
M base/task_scheduler/task_scheduler_impl.cc View 1 7 chunks +25 lines, -25 lines 0 comments Download
M base/task_scheduler/task_scheduler_impl_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Issue 2077093002 Patch 1
Issue 2077093002 Patch 20001

Messages

Total messages: 29 (15 generated)
robliao
4 years, 6 months ago (2016-06-14 22:16:20 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068853002/1
4 years, 6 months ago (2016-06-14 22:16:58 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ...
4 years, 6 months ago (2016-06-15 00:18:34 UTC) #6
robliao
Updated renames.
4 years, 6 months ago (2016-06-16 20:04:05 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068853002/40001
4 years, 6 months ago (2016-06-16 20:04:29 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-16 22:03:31 UTC) #13
fdoray
lgtm https://codereview.chromium.org/2068853002/diff/40001/base/task_scheduler/scheduler_service_thread_unittest.cc File base/task_scheduler/scheduler_service_thread_unittest.cc (right): https://codereview.chromium.org/2068853002/diff/40001/base/task_scheduler/scheduler_service_thread_unittest.cc#newcode57 base/task_scheduler/scheduler_service_thread_unittest.cc:57: "TestWorkerPoolForSchedulerThread", ThreadPriority::BACKGROUND, 1u, ForScheduler*Service*Thread
4 years, 6 months ago (2016-06-17 20:24:30 UTC) #14
robliao
danakj@chromium.org: Please review this name change CL. Thanks! https://codereview.chromium.org/2068853002/diff/40001/base/task_scheduler/scheduler_service_thread_unittest.cc File base/task_scheduler/scheduler_service_thread_unittest.cc (right): https://codereview.chromium.org/2068853002/diff/40001/base/task_scheduler/scheduler_service_thread_unittest.cc#newcode57 base/task_scheduler/scheduler_service_thread_unittest.cc:57: "TestWorkerPoolForSchedulerThread", ...
4 years, 6 months ago (2016-06-17 20:51:25 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068853002/60001
4 years, 6 months ago (2016-06-17 20:51:25 UTC) #18
danakj
LGTM
4 years, 6 months ago (2016-06-17 20:55:36 UTC) #20
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-17 22:02:23 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068853002/60001
4 years, 6 months ago (2016-06-22 17:02:31 UTC) #25
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 6 months ago (2016-06-22 18:16:55 UTC) #27
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 18:19:40 UTC) #29
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/624260a841365547b5687ecb14de7fe09fe01c9c
Cr-Commit-Position: refs/heads/master@{#401351}

Powered by Google App Engine
This is Rietveld 408576698