Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Issue 2068833003: base: Make TaskQueue a typedef instead of a subclass (Closed)

Created:
4 years, 6 months ago by danakj
Modified:
4 years, 6 months ago
Reviewers:
vmpstr
CC:
chromium-reviews, sadrul, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

base: Make TaskQueue a typedef instead of a subclass Subclassing STL types is bad. And std::queue::swap exists as of c++11. R=vmpstr Committed: https://crrev.com/5d79215245df21c35b5ff63d6c46deca5d1498f4 Cr-Commit-Position: refs/heads/master@{#400006}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -12 lines) Patch
M base/message_loop/incoming_task_queue.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/pending_task.h View 1 chunk +2 lines, -7 lines 0 comments Download
M base/pending_task.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
danakj
4 years, 6 months ago (2016-06-14 23:28:06 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068833003/1
4 years, 6 months ago (2016-06-14 23:28:56 UTC) #3
vmpstr
lgtm, thanks!
4 years, 6 months ago (2016-06-14 23:29:05 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/81444)
4 years, 6 months ago (2016-06-15 00:17:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068833003/1
4 years, 6 months ago (2016-06-15 00:18:54 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/200716)
4 years, 6 months ago (2016-06-15 00:32:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068833003/1
4 years, 6 months ago (2016-06-15 19:46:35 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-15 20:48:00 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 20:49:39 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d79215245df21c35b5ff63d6c46deca5d1498f4
Cr-Commit-Position: refs/heads/master@{#400006}

Powered by Google App Engine
This is Rietveld 408576698