Change Dart_DefaultCanonicalizeUrl to accept the library url string instead of a library, this is u…

Change Dart_DefaultCanonicalizeUrl to accept the library url string instead of a library, this is useful to allow us to use this to generically resolve a Uri relative to another string.

BUG=
R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/72f7d1456c355a82f336e0b2bc728b103363ee62

[siva, 2016-06-14 21:32:27]

asiva@google.com changed reviewers:
+ johnmccutchan@google.com, turnidge@google.com

[Cutch, 2016-06-14 21:38:31]

https://codereview.chromium.org/2068833002/diff/1/runtime/bin/dartutils.cc
File runtime/bin/dartutils.cc (right):

https://codereview.chromium.org/2068833002/diff/1/runtime/bin/dartutils.cc#ne...
runtime/bin/dartutils.cc:412: if (Dart_IsError(library_url)) {
Should this only happen if library_url is needed? Maybe under the:

if (tag == Dart_kCanonicalizeUrl) {
}

branch?

https://codereview.chromium.org/2068833002/diff/1/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

https://codereview.chromium.org/2068833002/diff/1/runtime/include/dart_api.h#...
runtime/include/dart_api.h:2695: * \param library_url The library url relative
to which the url is
s/library_url/base_url ?

[siva, 2016-06-14 22:23:29]

https://codereview.chromium.org/2068833002/diff/1/runtime/bin/dartutils.cc
File runtime/bin/dartutils.cc (right):

https://codereview.chromium.org/2068833002/diff/1/runtime/bin/dartutils.cc#ne...
runtime/bin/dartutils.cc:412: if (Dart_IsError(library_url)) {
On 2016/06/14 21:38:31, Cutch wrote:
> Should this only happen if library_url is needed? Maybe under the:
> 
> if (tag == Dart_kCanonicalizeUrl) {
> }
> 
> branch?

If you see further down in the else branch it does extract the library_url
invoking Dart_LibraryUrl(...), so I just hoisted that up.

https://codereview.chromium.org/2068833002/diff/1/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

https://codereview.chromium.org/2068833002/diff/1/runtime/include/dart_api.h#...
runtime/include/dart_api.h:2695: * \param library_url The library url relative
to which the url is
On 2016/06/14 21:38:31, Cutch wrote:
> s/library_url/base_url ? 

Done.

[Cutch, 2016-06-14 22:24:38]

lgtm

[siva, 2016-06-15 00:15:54]

Description was changed from

==========
Change Dart_DefaultCanonicalizeUrl to accept the library url string instead of a
library, this is useful to allow us to use this to generically resolve a Uri
relative to another string.

BUG=
==========

to

==========
Change Dart_DefaultCanonicalizeUrl to accept the library url string instead of a
library, this is useful to allow us to use this to generically resolve a Uri
relative to another string.

BUG=
R=johnmccutchan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/72f7d1456c355a82f336e0b2bc728b103363ee62
==========

[siva, 2016-06-15 00:15:56]

Committed patchset #2 (id:20001) manually as
72f7d1456c355a82f336e0b2bc728b103363ee62 (presubmit successful).