Issue 20688002: Patch to support Vtune on Android platform.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20688002: Patch to support Vtune on Android platform. (Closed)

Created:
7 years, 5 months ago by chunyang.dai

Modified:
7 years, 4 months ago

Reviewers:
haitao.feng, danno

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

This patch is to support Vtune on Android platform. The Vtune API provides the support for Android platform. So we fix the compilation issue and it works on Android platform.

Patch Set 1 : #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	src/third_party/vtune/vtune-jit.cc	View		1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

danno

lgtm. Please in the future press the "Publish+Mail Comments" link on the CL, otherwise I ...

7 years, 4 months ago (2013-07-29 12:31:55 UTC) #1

danno

lgtm. Please in the future press the "Publish+Mail Comments" link on the CL, otherwise I ...

7 years, 4 months ago (2013-07-29 12:31:56 UTC) #2

haitao.feng

7 years, 4 months ago (2013-07-30 01:15:30 UTC) #3

Sure, done. 

Committed patchset #1 manually as r15942.

Expand Messages | Collapse Messages