Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2068753002: Include CoreBluetooth.h from files that need it. (Closed)

Created:
4 years, 6 months ago by rohitrao (ping after 24h)
Modified:
4 years, 6 months ago
Reviewers:
Nico, justincohen
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Include CoreBluetooth.h from files that need it. BUG=619813 TEST=None Committed: https://crrev.com/e850f851231e6bcefcb2ef94643da2976b10c79e Cr-Commit-Position: refs/heads/master@{#399756}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M base/mac/sdk_forward_declarations.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
rohitrao (ping after 24h)
This appears to get iOS builds compiling after recent events. As far as I can ...
4 years, 6 months ago (2016-06-14 17:35:39 UTC) #2
rohitrao (ping after 24h)
The actual error messages were: In file included from ../../base/mac/mac_util.mm:23: ../../base/mac/sdk_forward_declarations.h:158:12: error: cannot find interface ...
4 years, 6 months ago (2016-06-14 17:53:54 UTC) #3
justincohen
LGTM!
4 years, 6 months ago (2016-06-14 17:54:20 UTC) #4
Nico
lgtm, thanks!
4 years, 6 months ago (2016-06-14 17:56:08 UTC) #5
Nico
(the bug is probably more about a new sdk than about a new xcode…i'm guessing ...
4 years, 6 months ago (2016-06-14 17:56:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068753002/1
4 years, 6 months ago (2016-06-14 17:58:56 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-14 18:38:51 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 18:40:14 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e850f851231e6bcefcb2ef94643da2976b10c79e
Cr-Commit-Position: refs/heads/master@{#399756}

Powered by Google App Engine
This is Rietveld 408576698