Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: src/compiler/typer.cc

Issue 2068743002: [builtins] Unify Atanh, Cbrt and Expm1 as exports from flibm. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fixed type warning. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/simplified-operator.cc ('k') | src/compiler/verifier.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/typer.cc
diff --git a/src/compiler/typer.cc b/src/compiler/typer.cc
index 7826e1703c7d809416a44170539aeca8967b511f..5127757f54ad89c54ece7f024ee16e281bebca2c 100644
--- a/src/compiler/typer.cc
+++ b/src/compiler/typer.cc
@@ -1801,10 +1801,15 @@ Type* Typer::Visitor::TypeNumberAtan(Node* node) { return Type::Number(); }
Type* Typer::Visitor::TypeNumberAtan2(Node* node) { return Type::Number(); }
+Type* Typer::Visitor::TypeNumberAtanh(Node* node) { return Type::Number(); }
+
Type* Typer::Visitor::TypeNumberExp(Node* node) {
return Type::Union(Type::PlainNumber(), Type::NaN(), zone());
}
+// TODO(mvstanton): Is this type sufficient, or should it look like Exp()?
+Type* Typer::Visitor::TypeNumberExpm1(Node* node) { return Type::Number(); }
+
Type* Typer::Visitor::TypeNumberLog(Node* node) { return Type::Number(); }
Type* Typer::Visitor::TypeNumberLog1p(Node* node) { return Type::Number(); }
@@ -1813,6 +1818,8 @@ Type* Typer::Visitor::TypeNumberLog2(Node* node) { return Type::Number(); }
Type* Typer::Visitor::TypeNumberLog10(Node* node) { return Type::Number(); }
+Type* Typer::Visitor::TypeNumberCbrt(Node* node) { return Type::Number(); }
+
Type* Typer::Visitor::TypeNumberRound(Node* node) {
return TypeUnaryOp(node, NumberRound);
}
@@ -2564,8 +2571,12 @@ Type* Typer::Visitor::TypeFloat64Atan(Node* node) { return Type::Number(); }
Type* Typer::Visitor::TypeFloat64Atan2(Node* node) { return Type::Number(); }
+Type* Typer::Visitor::TypeFloat64Atanh(Node* node) { return Type::Number(); }
+
Type* Typer::Visitor::TypeFloat64Exp(Node* node) { return Type::Number(); }
+Type* Typer::Visitor::TypeFloat64Expm1(Node* node) { return Type::Number(); }
+
Type* Typer::Visitor::TypeFloat64Log(Node* node) { return Type::Number(); }
Type* Typer::Visitor::TypeFloat64Log1p(Node* node) { return Type::Number(); }
@@ -2574,6 +2585,8 @@ Type* Typer::Visitor::TypeFloat64Log2(Node* node) { return Type::Number(); }
Type* Typer::Visitor::TypeFloat64Log10(Node* node) { return Type::Number(); }
+Type* Typer::Visitor::TypeFloat64Cbrt(Node* node) { return Type::Number(); }
+
Type* Typer::Visitor::TypeFloat64Sqrt(Node* node) { return Type::Number(); }
« no previous file with comments | « src/compiler/simplified-operator.cc ('k') | src/compiler/verifier.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698