Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp

Issue 2068723002: Paint local attachment backgrounds into composited scrolling contents layer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge allLayersAreLocal and ComputedStyle::hasEntirelyLocalBackground Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp
diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp
index 2328a074e1ea273a7cefc507a184623829d9ce95..48340a13b56ee05713cc599d501edd41d94c607e 100644
--- a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp
+++ b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp
@@ -641,12 +641,12 @@ TEST_F(CompositedLayerMappingTest, ShouldPaintBackgroundOntoScrollingContentsLay
" <div id='negative-composited-child' style='background-color: red; width: 1px; height: 1px; position: absolute; backface-visibility: hidden; z-index: -1'></div>"
" <div class='spacer'></div>"
"</div>"
- "<div id='scroller2' class='scroller' style='background: white content-box; padding: 10px;'>"
- " <div class='spacer'></div>"
- "</div>"
- "<div id='scroller3' class='scroller' style='background: white local content-box; padding: 10px;'>"
- " <div class='spacer'></div>"
- "</div>"
+ "<div id='scroller2' class='scroller' style='background: white content-box; padding: 10px;'><div class='spacer'></div></div>"
+ "<div id='scroller3' class='scroller' style='background: white local content-box; padding: 10px;'><div class='spacer'></div></div>"
+ "<div id='scroller4' class='scroller' style='background: url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUg), white local;'><div class='spacer'></div></div>"
+ "<div id='scroller5' class='scroller' style='background: url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUg) local, white local;'><div class='spacer'></div></div>"
+ "<div id='scroller6' class='scroller' style='background: url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUg) local, white padding-box; padding: 10px;'><div class='spacer'></div></div>"
+ "<div id='scroller7' class='scroller' style='background: url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUg) local, white content-box; padding: 10px;'><div class='spacer'></div></div>"
);
// First scroller cannot paint background into scrolling contents layer because it has a negative z-index child.
@@ -657,6 +657,20 @@ TEST_F(CompositedLayerMappingTest, ShouldPaintBackgroundOntoScrollingContentsLay
// Third scroller can paint background into scrolling contents layer.
EXPECT_TRUE(shouldPaintBackgroundOntoScrollingContentsLayer("scroller3"));
+
+ // Fourth scroller cannot paint background into scrolling contents layer because the background image is not locally attached.
+ EXPECT_FALSE(shouldPaintBackgroundOntoScrollingContentsLayer("scroller4"));
+
+ // Fifth scroller can paint background into scrolling contents layer because both the image and color are locally attached.
+ EXPECT_TRUE(shouldPaintBackgroundOntoScrollingContentsLayer("scroller5"));
+
+ // Sixth scroller can paint background into scrolling contents layer because the image is locally attached and even though
+ // the color is not, it is filled to the padding box so it will be drawn the same as a locally attached background.
+ EXPECT_TRUE(shouldPaintBackgroundOntoScrollingContentsLayer("scroller6"));
+
+ // Seventh scroller cannot paint background into scrolling contents layer because the color is filled to the content
+ // box and we have padding so it is not equivalent to a locally attached background.
+ EXPECT_FALSE(shouldPaintBackgroundOntoScrollingContentsLayer("scroller7"));
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698