third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-with-local-image-background.html - Issue 2068723002: Paint local attachment backgrounds into composited scrolling contents layer

Unified Diff: third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-with-local-image-background.html

Issue 2068723002: Paint local attachment backgrounds into composited scrolling contents layer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-with-local-background-expected.html ('k') | third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-with-local-image-background-expected.html » ('j') | third_party/WebKit/Source/core/layout/LayoutBox.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-with-local-image-background.html

diff --git a/third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-with-local-background.html b/third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-with-local-image-background.html

similarity index 57%

copy from third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-with-local-background.html

copy to third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-with-local-image-background.html

index 6dc6ab4a3803926001355062c47b297730883a16..2889ba3a58baef0595c262f0197ea20057271f30 100644

--- a/third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-with-local-background.html

+++ b/third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-with-local-image-background.html

@@ -5,7 +5,7 @@ onload = function() {

// Double rAF to ensure content is painted before scroll.

requestAnimationFrame(function() {

- document.getElementById('scroller').scrollTo(0, 200);

+ document.getElementById('scroller').scrollTop = 200;

if (window.testRunner)

window.testRunner.notifyDone();

})

@@ -14,7 +14,7 @@ onload = function() {

</script>

<style>

#scroller {

- background: gray local content-box;

+ background: url('../resources/apple.jpg') local;

border: 10px solid rgba(0, 255, 0, 0.5);

overflow: scroll;

padding: 10px;

@@ -27,11 +27,8 @@ onload = function() {

height: 300px;

}

</style>

-<!-- #scroller has a locally attached background with padding so when it is

- scrolled we can see the background slide up. Doing this on a composited

- element without repainting requires the background to be painted into

- the scrolling contents layer and correctly account for that layer not

- including the border in its bounds. -->

+<!-- This scroller has a locally attached background image which should

+ scroll with the content. -->

</div>

trchen 2016/08/17 01:22:55 Wow, this test actually failed without your CL. I