Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6556)

Unified Diff: chrome/test/data/webui/settings/people_page_manage_profile_test.js

Issue 2068713003: Refactors profile avatar selector into a Polymer element to use in md-settings & md-user-manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/settings/people_page_manage_profile_test.js
diff --git a/chrome/test/data/webui/settings/people_page_manage_profile_test.js b/chrome/test/data/webui/settings/people_page_manage_profile_test.js
index ba0b3a74fcf66bc88150c3f9cf0721ed979a8e70..432b448c2c86e687b167974e06f60be41b8211d0 100644
--- a/chrome/test/data/webui/settings/people_page_manage_profile_test.js
+++ b/chrome/test/data/webui/settings/people_page_manage_profile_test.js
@@ -21,7 +21,8 @@ cr.define('settings_people_page_manage_profile', function() {
/** @override */
getAvailableIcons: function() {
this.methodCalled('getAvailableIcons');
- return Promise.resolve(['fake-icon-1.png', 'fake-icon-2.png']);
+ return Promise.resolve([{url: 'fake-icon-1.png', label: 'fake-icon-1'},
+ {url: 'fake-icon-2.png', label: 'fake-icon-2'}]);
},
/** @override */
@@ -52,13 +53,13 @@ cr.define('settings_people_page_manage_profile', function() {
// - has the correct icon selected
// - can select a new icon
test('ManageProfileChangeIcon', function() {
- var selector = manageProfile.$.selector;
+ var selector = manageProfile.$.selector.$.selector;
assertTrue(!!selector);
return browserProxy.whenCalled('getAvailableIcons').then(function() {
Polymer.dom.flush();
- assertEquals('fake-icon-1.png', selector.selected);
+ assertEquals('fake-icon-1.png', manageProfile.profileIconUrl);
assertEquals(2, selector.items.length);
assertTrue(selector.items[0].classList.contains('iron-selected'));
assertFalse(selector.items[1].classList.contains('iron-selected'));
@@ -74,7 +75,7 @@ cr.define('settings_people_page_manage_profile', function() {
// Tests profile icon updates pushed from the browser.
test('ManageProfileIconUpdated', function() {
- var selector = manageProfile.$.selector;
+ var selector = manageProfile.$.selector.$.selector;
assertTrue(!!selector);
return browserProxy.whenCalled('getAvailableIcons').then(function() {
@@ -82,7 +83,7 @@ cr.define('settings_people_page_manage_profile', function() {
Polymer.dom.flush();
- assertEquals('fake-icon-2.png', selector.selected);
+ assertEquals('fake-icon-2.png', manageProfile.profileIconUrl);
assertEquals(2, selector.items.length);
assertFalse(selector.items[0].classList.contains('iron-selected'));
assertTrue(selector.items[1].classList.contains('iron-selected'));

Powered by Google App Engine
This is Rietveld 408576698