Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1147)

Unified Diff: chrome/browser/ui/webui/settings/settings_manage_profile_handler_unittest.cc

Issue 2068713003: Refactors profile avatar selector into a Polymer element to use in md-settings & md-user-manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/settings_manage_profile_handler_unittest.cc
diff --git a/chrome/browser/ui/webui/settings/settings_manage_profile_handler_unittest.cc b/chrome/browser/ui/webui/settings/settings_manage_profile_handler_unittest.cc
index 6c8a5056e0241d483e1778b3935540cb78ed211f..01362e6f25f46a099253852ce128780ed1c162fb 100644
--- a/chrome/browser/ui/webui/settings/settings_manage_profile_handler_unittest.cc
+++ b/chrome/browser/ui/webui/settings/settings_manage_profile_handler_unittest.cc
@@ -46,15 +46,21 @@ class ManageProfileHandlerTest : public testing::Test {
}
void VerifyIconList(const base::Value* value) {
- const base::ListValue* icon_urls = nullptr;
- ASSERT_TRUE(value->GetAsList(&icon_urls));
-
- // Expect the list of icon URLs to be a non-empty list of non-empty strings.
- EXPECT_FALSE(icon_urls->empty());
- for (size_t i = 0; i < icon_urls->GetSize(); ++i) {
+ const base::ListValue* icons = nullptr;
+ ASSERT_TRUE(value->GetAsList(&icons));
+
+ // Expect a non-empty list of dictionaries containing non-empty strings for
+ // profile avatar icon urls and labels.
+ EXPECT_FALSE(icons->empty());
+ for (size_t i = 0; i < icons->GetSize(); ++i) {
+ const base::DictionaryValue* icon = nullptr;
+ EXPECT_TRUE(icons->GetDictionary(i, &icon));
std::string icon_url;
- EXPECT_TRUE(icon_urls->GetString(i, &icon_url));
+ EXPECT_TRUE(icon->GetString("url", &icon_url));
EXPECT_FALSE(icon_url.empty());
+ std::string icon_label;
+ EXPECT_TRUE(icon->GetString("label", &icon_label));
+ EXPECT_FALSE(icon_label.empty());
}
}

Powered by Google App Engine
This is Rietveld 408576698