Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2910)

Unified Diff: chrome/browser/resources/settings/people_page/manage_profile.js

Issue 2068713003: Refactors profile avatar selector into a Polymer element to use in md-settings & md-user-manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/people_page/manage_profile.js
diff --git a/chrome/browser/resources/settings/people_page/manage_profile.js b/chrome/browser/resources/settings/people_page/manage_profile.js
index 2851f688a4de9900de3797e8d5618987523382dc..70284914cfaeb6f1e0ec11f734bae53653b19501 100644
--- a/chrome/browser/resources/settings/people_page/manage_profile.js
+++ b/chrome/browser/resources/settings/people_page/manage_profile.js
@@ -27,7 +27,7 @@ Polymer({
* The available icons for selection.
* @type {!Array<string>}
*/
- availableIconUrls: {
+ availableIcons: {
type: Array,
value: function() { return []; },
},
@@ -45,8 +45,8 @@ Polymer({
/** @override */
attached: function() {
- var setIcons = function(iconUrls) {
- this.availableIconUrls = iconUrls;
+ var setIcons = function(icons) {
+ this.availableIcons = icons;
}.bind(this);
this.addWebUIListener('available-icons-changed', setIcons);
@@ -67,14 +67,12 @@ Polymer({
},
/**
- * Handler for when the an image is activated.
+ * Handler for when an avatar is activated.
* @param {!Event} event
* @private
*/
onIconActivate_: function(event) {
- /** @type {{iconUrl: string}} */
- var buttonData = event.detail.item.dataset;
- this.browserProxy_.setProfileIconAndName(buttonData.iconUrl,
+ this.browserProxy_.setProfileIconAndName(event.detail.selected,
this.profileName);
},
});

Powered by Google App Engine
This is Rietveld 408576698