Refactors profile avatar selector into a Polymer element to use in md-settings & md-user-manager

chrome/browser/ui/webui/settings/settings_manage_profile_handler_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/settings/settings_manage_profile_handler.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/base/testing_browser_process.h"
 #include "chrome/test/base/testing_profile_manager.h"
@@ skipping 28 matching lines @@
     ASSERT_TRUE(profile_manager_.SetUp());
     profile_ = profile_manager_.CreateTestingProfile("Profile 1");
 
     handler_.reset(new TestManageProfileHandler(profile_));
     handler_->set_web_ui(&web_ui_);
     handler()->AllowJavascript();
     web_ui()->ClearTrackedCalls();
   }
 
   void VerifyIconList(const base::Value* value) {
-    const base::ListValue* icon_urls = nullptr;
-    ASSERT_TRUE(value->GetAsList(&icon_urls));
+    const base::ListValue* icons = nullptr;
+    ASSERT_TRUE(value->GetAsList(&icons));
 
     // Expect the list of icon URLs to be a non-empty list of non-empty strings.

[michaelpg, 2016/06/20 17:01:10]

update/remove comment

[Moe, 2016/06/20 18:48:56]

Done.

-    EXPECT_FALSE(icon_urls->empty());
-    for (size_t i = 0; i < icon_urls->GetSize(); ++i) {
+    EXPECT_FALSE(icons->empty());
+    for (size_t i = 0; i < icons->GetSize(); ++i) {
+      const base::DictionaryValue* icon = nullptr;
+      EXPECT_TRUE(icons->GetDictionary(i, &icon));
       std::string icon_url;
-      EXPECT_TRUE(icon_urls->GetString(i, &icon_url));
+      EXPECT_TRUE(icon->GetString("url", &icon_url));
       EXPECT_FALSE(icon_url.empty());
+      std::string icon_label;
+      EXPECT_TRUE(icon->GetString("label", &icon_label));
+      EXPECT_FALSE(icon_label.empty());
     }
   }
 
   content::TestWebUI* web_ui() { return &web_ui_; }
   Profile* profile() const { return profile_; }
   TestManageProfileHandler* handler() const { return handler_.get(); }
 
  private:
   content::TestBrowserThreadBundle thread_bundle_;
   TestingProfileManager profile_manager_;
@@ skipping 43 matching lines @@
   EXPECT_EQ("cr.webUIListenerCallback", data.function_name());
 
   std::string event_id;
   ASSERT_TRUE(data.arg1()->GetAsString(&event_id));
   EXPECT_EQ("available-icons-changed", event_id);
 
   VerifyIconList(data.arg2());
 }
 
 }  // namespace settings