Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(971)

Issue 2068693003: [stubs] Ensure that StoreTransitionStub does not bailout after the properties backing store is enla… (Closed)

Created:
4 years, 6 months ago by Igor Sheludko
Modified:
4 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Ensure that StoreTransitionStub does not bailout after the properties backing store is enlarged. In addition, this CL fixes --trace-hydrogen-stubs mode. BUG=chromium:601420 LOG=Y Committed: https://crrev.com/7446a74f94e2117f22e2b26f9f1ad1d7d7c3668d Cr-Commit-Position: refs/heads/master@{#36971}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -12 lines) Patch
M src/code-stubs-hydrogen.cc View 3 chunks +17 lines, -5 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +8 lines, -6 lines 0 comments Download
M src/deoptimizer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068693003/20001
4 years, 6 months ago (2016-06-14 14:03:13 UTC) #4
Igor Sheludko
PTAL
4 years, 6 months ago (2016-06-14 14:03:16 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-14 14:30:05 UTC) #8
Jakob Kummerow
Good catch, thanks! LGTM. A regression test is probably going to be hard to come ...
4 years, 6 months ago (2016-06-14 14:32:15 UTC) #9
Igor Sheludko
On 2016/06/14 14:32:15, Jakob wrote: > Good catch, thanks! LGTM. > > A regression test ...
4 years, 6 months ago (2016-06-14 14:35:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068693003/20001
4 years, 6 months ago (2016-06-14 14:35:23 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 6 months ago (2016-06-14 14:37:08 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 14:39:03 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7446a74f94e2117f22e2b26f9f1ad1d7d7c3668d
Cr-Commit-Position: refs/heads/master@{#36971}

Powered by Google App Engine
This is Rietveld 408576698