Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3698)

Unified Diff: chrome/browser/resources/settings/people_page/sync_page.html

Issue 2068653003: Settings People Revamp: Add Payments integration to new Sync Settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/people_page/sync_page.html
diff --git a/chrome/browser/resources/settings/people_page/sync_page.html b/chrome/browser/resources/settings/people_page/sync_page.html
index 3a8ce995b0e9d92c34218a7621363e21aa7f5e6b..ec9ed455a0df729e41283bd8773da00e3d9748b3 100644
--- a/chrome/browser/resources/settings/people_page/sync_page.html
+++ b/chrome/browser/resources/settings/people_page/sync_page.html
@@ -48,13 +48,17 @@
syncPrefs.syncAllDataTypes, syncPrefs.appsEnforced)]]">
$i18n{appCheckboxLabel}
</paper-checkbox>
+
+ <!-- Autofill has a special on-change handler to deal with
+ Payments integriation. -->
<paper-checkbox checked="{{syncPrefs.autofillSynced}}"
- on-change="onSingleSyncDataTypeChanged_" class="list-item"
+ on-change="onAutofillDataTypeChanged_" class="list-item"
hidden="[[!syncPrefs.autofillRegistered]]"
disabled="[[shouldSyncCheckboxBeDisabled_(
syncPrefs.syncAllDataTypes, syncPrefs.autofillEnforced)]]">
$i18n{autofillCheckboxLabel}
</paper-checkbox>
+
<paper-checkbox checked="{{syncPrefs.bookmarksSynced}}"
on-change="onSingleSyncDataTypeChanged_" class="list-item"
hidden="[[!syncPrefs.bookmarksRegistered]]"
@@ -104,6 +108,20 @@
syncPrefs.syncAllDataTypes, syncPrefs.tabsEnforced)]]">
$i18n{openTabsCheckboxLabel}
</paper-checkbox>
+
+ <!-- The Payments integration checkbox is a special case in many ways.
+ It's visible only if autofill is registered. It's disabled and
+ unchecked if autofill is unchecked.-->
+ <paper-checkbox checked="{{syncPrefs.paymentsIntegrationEnabled}}"
+ on-change="onSingleSyncDataTypeChanged_" class="list-item"
+ hidden="[[!syncPrefs.autofillRegistered]]"
+ disabled="[[shouldPaymentsCheckboxBeDisabled_(
+ syncPrefs.syncAllDataTypes, syncPrefs.autofillSynced)]]">
+ $i18n{enablePaymentsIntegrationCheckboxLabel}
+ <a href="$i18nRaw{autofillHelpURL}" target="_blank">
+ $i18n{learnMore}
+ </a>
+ </paper-checkbox>
</div>
<div class="settings-box two-line" on-tap="onManageSyncedDataTap_">

Powered by Google App Engine
This is Rietveld 408576698