Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2068633002: Revert "Make VM resolvePackageUri fail on package:foo and package:/foo." (Closed)

Created:
4 years, 6 months ago by Lasse Reichstein Nielsen
Modified:
4 years, 6 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Make VM resolvePackageUri fail on package:foo and package:/foo." There were some tests of the changed behavior. R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/a5aebce4b72ccfdf58e373545cba5028ac8e6236

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -21 lines) Patch
M runtime/bin/vmservice/loader.dart View 5 chunks +13 lines, -20 lines 0 comments Download
M tests/standalone/packages_file_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Lasse Reichstein Nielsen
4 years, 6 months ago (2016-06-14 08:52:11 UTC) #2
Bill Hesse
lgtm
4 years, 6 months ago (2016-06-14 08:52:41 UTC) #4
Lasse Reichstein Nielsen
4 years, 6 months ago (2016-06-14 08:53:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a5aebce4b72ccfdf58e373545cba5028ac8e6236.

Powered by Google App Engine
This is Rietveld 408576698