Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: src/x87/macro-assembler-x87.cc

Issue 2068603002: [debugger] simplify debug stepping. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix completion callback Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/x87/builtins-x87.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X87 5 #if V8_TARGET_ARCH_X87
6 6
7 #include "src/base/bits.h" 7 #include "src/base/bits.h"
8 #include "src/base/division-by-constant.h" 8 #include "src/base/division-by-constant.h"
9 #include "src/bootstrapper.h" 9 #include "src/bootstrapper.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 2284 matching lines...) Expand 10 before | Expand all | Expand 10 after
2295 } 2295 }
2296 bind(&invoke); 2296 bind(&invoke);
2297 } 2297 }
2298 } 2298 }
2299 2299
2300 2300
2301 void MacroAssembler::FloodFunctionIfStepping(Register fun, Register new_target, 2301 void MacroAssembler::FloodFunctionIfStepping(Register fun, Register new_target,
2302 const ParameterCount& expected, 2302 const ParameterCount& expected,
2303 const ParameterCount& actual) { 2303 const ParameterCount& actual) {
2304 Label skip_flooding; 2304 Label skip_flooding;
2305 ExternalReference step_in_enabled = 2305 ExternalReference last_step_action =
2306 ExternalReference::debug_step_in_enabled_address(isolate()); 2306 ExternalReference::debug_last_step_action_address(isolate());
2307 cmpb(Operand::StaticVariable(step_in_enabled), Immediate(0)); 2307 STATIC_ASSERT(StepFrame > StepIn);
2308 j(equal, &skip_flooding); 2308 cmpb(Operand::StaticVariable(last_step_action), Immediate(StepIn));
2309 j(less, &skip_flooding);
2309 { 2310 {
2310 FrameScope frame(this, 2311 FrameScope frame(this,
2311 has_frame() ? StackFrame::NONE : StackFrame::INTERNAL); 2312 has_frame() ? StackFrame::NONE : StackFrame::INTERNAL);
2312 if (expected.is_reg()) { 2313 if (expected.is_reg()) {
2313 SmiTag(expected.reg()); 2314 SmiTag(expected.reg());
2314 Push(expected.reg()); 2315 Push(expected.reg());
2315 } 2316 }
2316 if (actual.is_reg()) { 2317 if (actual.is_reg()) {
2317 SmiTag(actual.reg()); 2318 SmiTag(actual.reg());
2318 Push(actual.reg()); 2319 Push(actual.reg());
(...skipping 983 matching lines...) Expand 10 before | Expand all | Expand 10 after
3302 mov(eax, dividend); 3303 mov(eax, dividend);
3303 shr(eax, 31); 3304 shr(eax, 31);
3304 add(edx, eax); 3305 add(edx, eax);
3305 } 3306 }
3306 3307
3307 3308
3308 } // namespace internal 3309 } // namespace internal
3309 } // namespace v8 3310 } // namespace v8
3310 3311
3311 #endif // V8_TARGET_ARCH_X87 3312 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « src/x87/builtins-x87.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698