Issue 20686002: Profile Reset: enable feature by default

Issue 20686002: Profile Reset: enable feature by default (Closed)

Created:
7 years, 5 months ago by vasilii

Modified:
7 years, 4 months ago

Reviewers:
Dan Beam, battre

CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Profile Reset: Get rid of the flag in about:flags. BUG=235037 TBR=battre@chromium.org, dbeam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214376

Patch Set 2 : Enable flag by default #

Patch Set 3 : Allow disabling feature through Finch #

Patch Set 4 : disable -> enable #

Total comments: 2

Patch Set 5 : CamelCase #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	chrome/browser/ui/webui/options/browser_options_handler.cc	View	1 2 3 4	3 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 14 (0 generated)

Expand Messages | Collapse Messages

vasilii

Hi! The "Profile Reset" feature is almost ready for release. Therefore, I enable it in ...

7 years, 5 months ago (2013-07-26 08:39:22 UTC) #1

battre

For now I think that you should not remove the flag, only toggle its default ...

7 years, 5 months ago (2013-07-26 11:22:36 UTC) #2

Dan Beam

On 2013/07/26 11:22:36, battre wrote: > For now I think that you should not remove ...

7 years, 5 months ago (2013-07-26 18:23:51 UTC) #3

vasilii

On 2013/07/26 18:23:51, Dan Beam wrote: > On 2013/07/26 11:22:36, battre wrote: > > For ...

7 years, 4 months ago (2013-07-29 12:50:36 UTC) #4

battre

I think I will defer to Dan as I am not familiar with this code.

7 years, 4 months ago (2013-07-29 13:38:00 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vasilii@chromium.org/20686002/11001

7 years, 4 months ago (2013-07-30 15:35:02 UTC) #7

vasilii

On 2013/07/30 15:35:02, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...

7 years, 4 months ago (2013-07-30 15:39:29 UTC) #8

battre

https://codereview.chromium.org/20686002/diff/30001/chrome/browser/ui/webui/options/browser_options_handler.cc File chrome/browser/ui/webui/options/browser_options_handler.cc (right): https://codereview.chromium.org/20686002/diff/30001/chrome/browser/ui/webui/options/browser_options_handler.cc#newcode130 chrome/browser/ui/webui/options/browser_options_handler.cc:130: const char kProfileResetTrialName[] = "manual_reset_profile"; This should be CamelCase.

7 years, 4 months ago (2013-07-30 17:04:41 UTC) #10

vasilii

7 years, 4 months ago (2013-07-30 17:09:07 UTC) #11

battre

I think this is trivial enough that you can TBR Dan for OWNER's approval.

7 years, 4 months ago (2013-07-30 17:09:22 UTC) #12

vasilii

Committed patchset #5 manually as r214376 (presubmit successful).

7 years, 4 months ago (2013-07-30 17:11:54 UTC) #13

commit-bot: I haz the power

7 years, 4 months ago (2013-07-30 20:26:15 UTC) #14

Message was sent while issue was closed.

Failed to trigger a try job on win_rel
HTTP Error 400: Bad Request

Expand Messages | Collapse Messages