tests_lit/asan_tests/startinitcall.ll - Issue 2068593003: Implemented linking to a dummy ASan runtime

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tests_lit/asan_tests/startinitcall.ll

Issue 2068593003: Implemented linking to a dummy ASan runtime (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fixes in szbuild.py Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 ; Test for a call to __asan_init in _start

	2

	3 ; REQUIRES: allow_dump

	4

	5 ; RUN: %p2i -i %s --args -verbose=inst -threads=0 -fsanitize-address \

	6 ; RUN: \| FileCheck --check-prefix=DUMP %s

	7

	8 ; notStart() should not be instrumented

	9 define internal void @notStart() {

	10 ret void

	11 }

	12

	13 ; DUMP-LABEL: ================ Instrumented CFG ================

	14 ; DUMP-NEXT: define internal void @notStart(
	Karl 2016/06/15 14:19:28 Wouldn't be safer to make this the DUMP-LABEL entr Wouldn't be safer to make this the DUMP-LABEL entry, since it has the name of the function. By using that as the label, you protect this test from function reordering during compilation, or other forms of code insertion. tlively 2016/06/15 16:32:00 Done. Show quoted text On 2016/06/15 14:19:28, Karl wrote: > Wouldn't be safer to make this the DUMP-LABEL entry, since it has the name of > the function. By using that as the label, you protect this test from function > reordering during compilation, > or other forms of code insertion. Done.
	15 ; DUMP-NEXT: __0:

	16 ; DUMP-NOT: __asan_init()

	17 ; DUMP: }

	18

	19 ; _start() should be instrumented

	20 define void @_start() {

	21 ret void

	22 }

	23

	24 ; DUMP-LABEL: ================ Instrumented CFG ================

	25 ; DUMP-NEXT: define void @_start(
	Karl 2016/06/15 14:19:28 Same here. Same here. tlively 2016/06/15 16:32:00 Done. Show quoted text On 2016/06/15 14:19:28, Karl wrote: > Same here. Done.
	26 ; DUMP-NEXT: __0:

	27 ; DUMP-NEXT: call void @__asan_init()

OLD	NEW

« no previous file with comments | « tests_lit/asan_tests/globalredzones.ll ('k') | no next file » | no next file with comments »