Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Issue 2068593002: [Media Router] Assign each route a current cast mode if possible (Closed)

Created:
4 years, 6 months ago by btolsch
Modified:
4 years, 6 months ago
Reviewers:
apacible
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

[Media Router] Assign each route a current cast mode if possible This change gives each media route in the WebUI a current cast mode value if its media source corresponds to one of the currently available cast modes. This is to prevent showing the 'cast' button that allows replacing the route when the new route would effectively be a copy of the original route. BUG=614144 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2040883002 Cr-Commit-Position: refs/heads/master@{#398687} (cherry picked from commit a47d5b0506c1183d501767d17ffec02ca419ea76)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+514 lines, -101 lines) Patch
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js View 4 chunks +21 lines, -28 lines 0 comments Download
M chrome/browser/resources/media_router/elements/route_details/route_details.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/media_router/elements/route_details/route_details.js View 3 chunks +60 lines, -14 lines 0 comments Download
M chrome/browser/resources/media_router/media_router_data.js View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_ui.h View 5 chunks +13 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_ui.cc View 4 chunks +26 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc View 4 chunks +106 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_webui_message_handler.h View 2 chunks +13 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc View 5 chunks +34 lines, -11 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc View 4 chunks +12 lines, -2 lines 0 comments Download
M chrome/test/data/webui/media_router/media_router_container_route_tests.js View 3 chunks +169 lines, -0 lines 0 comments Download
M chrome/test/data/webui/media_router/media_router_container_test_base.js View 3 chunks +16 lines, -3 lines 0 comments Download
M chrome/test/data/webui/media_router/route_details_tests.js View 5 chunks +36 lines, -21 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
btolsch
Merge to M52, had to undo CallJavascriptFunctionUnsafe function rename because it hasn't been merged to ...
4 years, 6 months ago (2016-06-14 00:42:42 UTC) #2
apacible
rs lgtm
4 years, 6 months ago (2016-06-14 04:15:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068593002/1
4 years, 6 months ago (2016-06-14 07:23:22 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 07:26:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698