Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2068553002: Manually rebaseline 10 tests after 399384 (Closed)

Created:
4 years, 6 months ago by pdr.
Modified:
4 years, 6 months ago
Reviewers:
wkorman
CC:
blink-reviews, chromium-reviews, perkj_chrome
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Manually rebaseline 10 tests after 399384 This patch manually rebaselines 10 tests after: https://crrev.com/6c46c2c4123213eb9a684a1df9ec22cccea39d52 This patch also reverts suppressions added in: https://crrev.com/89ac1777f53c26ac798acccef38cb5506cf901a1 Rebaseline bot bug discussion: https://bugs.chromium.org/p/chromium/issues/detail?id=574272#c12 svg/custom/js-late-clipPath-and-object-creation.svg svg/custom/js-late-clipPath-creation.svg svg/custom/marker-viewBox-changes.svg svg/custom/relative-sized-content.xhtml svg/custom/relative-sized-deep-shadow-tree-content.xhtml svg/custom/relative-sized-image.xhtml svg/custom/relative-sized-shadow-tree-content.xhtml svg/custom/resource-invalidate-on-target-update.svg svg/filters/feImage-target-attribute-change-with-use-indirection.svg svg/repaint/inner-svg-change-viewBox-contract.svg svg/repaint/mask-clip-target-transform.svg BUG=619108 TBR=wkorman@chromium.org Committed: https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4 Cr-Commit-Position: refs/heads/master@{#399623}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -254 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -9 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/android/svg/repaint/inner-svg-change-viewBox-contract-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/android/svg/repaint/mask-clip-target-transform-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux-precise/svg/repaint/inner-svg-change-viewBox-contract-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux-precise/svg/repaint/inner-svg-change-viewBox-contract-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux-precise/svg/repaint/mask-clip-target-transform-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux-precise/svg/repaint/mask-clip-target-transform-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/custom/js-late-clipPath-and-object-creation-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/custom/js-late-clipPath-and-object-creation-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/custom/js-late-clipPath-creation-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/custom/js-late-clipPath-creation-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/custom/marker-viewBox-changes-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/custom/marker-viewBox-changes-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/custom/relative-sized-content-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/custom/relative-sized-content-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/custom/relative-sized-deep-shadow-tree-content-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/custom/relative-sized-image-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/custom/relative-sized-image-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/custom/relative-sized-shadow-tree-content-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/custom/relative-sized-shadow-tree-content-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/custom/resource-invalidate-on-target-update-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/custom/resource-invalidate-on-target-update-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/custom/js-late-clipPath-and-object-creation-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/custom/js-late-clipPath-and-object-creation-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/custom/js-late-clipPath-creation-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/custom/js-late-clipPath-creation-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/custom/marker-viewBox-changes-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/custom/marker-viewBox-changes-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/custom/relative-sized-content-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/custom/relative-sized-content-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/custom/relative-sized-deep-shadow-tree-content-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/custom/relative-sized-image-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/custom/relative-sized-image-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/custom/relative-sized-shadow-tree-content-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/custom/relative-sized-shadow-tree-content-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/custom/resource-invalidate-on-target-update-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/custom/resource-invalidate-on-target-update-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/js-late-clipPath-and-object-creation-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/js-late-clipPath-and-object-creation-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/js-late-clipPath-creation-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/js-late-clipPath-creation-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/marker-viewBox-changes-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/marker-viewBox-changes-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/relative-sized-content-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/relative-sized-content-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/relative-sized-deep-shadow-tree-content-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/relative-sized-image-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/relative-sized-image-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/relative-sized-shadow-tree-content-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/relative-sized-shadow-tree-content-expected.txt View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/resource-invalidate-on-target-update-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/resource-invalidate-on-target-update-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/svg/repaint/inner-svg-change-viewBox-contract-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win/svg/repaint/inner-svg-change-viewBox-contract-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/svg/repaint/mask-clip-target-transform-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win/svg/repaint/mask-clip-target-transform-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win7/svg/custom/js-late-clipPath-and-object-creation-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win7/svg/custom/js-late-clipPath-creation-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win7/svg/custom/marker-viewBox-changes-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win7/svg/custom/relative-sized-content-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win7/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win7/svg/custom/relative-sized-image-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win7/svg/custom/relative-sized-shadow-tree-content-expected.txt View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win7/svg/custom/resource-invalidate-on-target-update-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win7/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win7/svg/repaint/inner-svg-change-viewBox-contract-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win7/svg/repaint/inner-svg-change-viewBox-contract-expected.txt View 1 chunk +23 lines, -7 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win7/svg/repaint/mask-clip-target-transform-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win7/svg/repaint/mask-clip-target-transform-expected.txt View 1 chunk +43 lines, -18 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
pdr.
4 years, 6 months ago (2016-06-13 22:40:30 UTC) #3
wkorman
lgtm
4 years, 6 months ago (2016-06-13 22:43:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068553002/1
4 years, 6 months ago (2016-06-13 23:02:15 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-14 00:43:11 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-14 00:43:15 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 00:44:59 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4
Cr-Commit-Position: refs/heads/master@{#399623}

Powered by Google App Engine
This is Rietveld 408576698