Issue 206853003: Add new experimental API to SkPicture to get "id" of current op

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 206853003: Add new experimental API to SkPicture to get "id" of current op (Closed)

Created:
6 years, 9 months ago by robertphillips

Modified:
6 years, 9 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Add new experimental API to SkPicture to get "id" of current op When gathering information about a picture (in the new SkDevice::EXPERIMENTAL_optimize entry point) it is necessary to be able to correlate the gathered information with the command in the SkPicture (so the information can later be combined with the similarly indexed information from the BBH). This entry point exposes that information to friend classes. Committed: http://code.google.com/p/skia/source/detail?r=13919

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -3 lines)			Patch
M	include/core/SkPicture.h	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/core/SkPicture.cpp	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/core/SkPicturePlayback.h	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	src/core/SkPicturePlayback.cpp	View	3 chunks	+20 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

robertphillips

The CQ bit was checked by robertphillips@google.com

6 years, 9 months ago (2014-03-24 18:08:47 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/206853003/1

6 years, 9 months ago (2014-03-24 18:08:52 UTC) #4

Message was sent while issue was closed.

Change committed as 13919

Expand Messages | Collapse Messages