Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 206853002: IPC: Fix size_t to int cast for Win64 build. (Closed)

Created:
6 years, 9 months ago by epenner
Modified:
6 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@IPC_perftests
Visibility:
Public.

Description

IPC: Fix size_t to int cast for Win64 build. BUG= TBR=cpu@chromium.org NOTRY=true No try as this is blocking the Win64 build. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258456

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ipc/ipc_perftests.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
epennerAtGoogle
Ptal. This target isn't on Win64 bots so a compiler warning slipped in. I'm TBR'ing ...
6 years, 9 months ago (2014-03-20 20:45:05 UTC) #1
epenner
The CQ bit was checked by epenner@chromium.org
6 years, 9 months ago (2014-03-20 20:46:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/epenner@chromium.org/206853002/1
6 years, 9 months ago (2014-03-20 20:48:21 UTC) #3
Will Harris
LGTM
6 years, 9 months ago (2014-03-20 20:53:44 UTC) #4
cpu_(ooo_6.6-7.5)
lgtm
6 years, 9 months ago (2014-03-20 22:37:29 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 23:10:06 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=285491
6 years, 9 months ago (2014-03-20 23:10:07 UTC) #7
epenner
The CQ bit was checked by epenner@chromium.org
6 years, 9 months ago (2014-03-20 23:32:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/epenner@chromium.org/206853002/1
6 years, 9 months ago (2014-03-20 23:34:18 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-20 23:36:26 UTC) #10
Message was sent while issue was closed.
Change committed as 258456

Powered by Google App Engine
This is Rietveld 408576698