Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 2068523002: Fix compile error (uninitialized variable use) (Closed)

Created:
4 years, 6 months ago by Brian Osman
Modified:
4 years, 6 months ago
Reviewers:
jvanverth1, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix compile error (uninitialized variable use) switch is already handling all cases, but some compilers don't care. This suppresses errors about potentially using vkLoadOp and vkStoreOp uninitialized. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2068523002 Committed: https://skia.googlesource.com/skia/+/0bbc3713de2f51c17fad935ccfd87dd68c7062ef

Patch Set 1 #

Patch Set 2 : Let's abort if this ever happens. It shouldn't. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/gpu/vk/GrVkGpuCommandBuffer.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068523002/1
4 years, 6 months ago (2016-06-13 21:26:22 UTC) #4
Brian Osman
4 years, 6 months ago (2016-06-13 21:27:47 UTC) #6
Brian Osman
Now with more crashing.
4 years, 6 months ago (2016-06-13 21:33:05 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068523002/20001
4 years, 6 months ago (2016-06-13 21:33:41 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-13 21:56:15 UTC) #11
jvanverth1
lgtm
4 years, 6 months ago (2016-06-13 21:59:29 UTC) #12
egdaniel
lgtm
4 years, 6 months ago (2016-06-13 21:59:42 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068523002/20001
4 years, 6 months ago (2016-06-14 11:52:15 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 11:53:13 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/0bbc3713de2f51c17fad935ccfd87dd68c7062ef

Powered by Google App Engine
This is Rietveld 408576698