Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2068483002: Add an unconditional version of DispatcherAddAwakable(): AddAwakableUnconditional(). (Closed)

Created:
4 years, 6 months ago by viettrungluu
Modified:
4 years, 6 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add an unconditional version of DispatcherAddAwakable(): AddAwakableUnconditional(). This version adds the awakable even if the signals are already satisfied. This will be needed for wait sets, which will have persistent awakables. R=vardhan@google.com BUG=#350 Committed: https://chromium.googlesource.com/external/mojo/+/6ff1cf89b1435a6f13662f33a27059eb9d2ba443

Patch Set 1 #

Patch Set 2 : oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+272 lines, -211 lines) Patch
M mojo/edk/system/channel_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M mojo/edk/system/core_test_base.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/data_pipe.h View 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/edk/system/data_pipe.cc View 4 chunks +6 lines, -0 lines 0 comments Download
M mojo/edk/system/data_pipe_consumer_dispatcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/data_pipe_consumer_dispatcher.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/edk/system/data_pipe_impl_unittest.cc View 61 chunks +120 lines, -116 lines 0 comments Download
M mojo/edk/system/data_pipe_producer_dispatcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/data_pipe_producer_dispatcher.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/edk/system/dispatcher.h View 3 chunks +10 lines, -1 line 0 comments Download
M mojo/edk/system/dispatcher.cc View 2 chunks +18 lines, -1 line 0 comments Download
M mojo/edk/system/local_message_pipe_endpoint.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/local_message_pipe_endpoint.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/edk/system/message_pipe.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/message_pipe.cc View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/edk/system/message_pipe_dispatcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/message_pipe_dispatcher.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/edk/system/message_pipe_endpoint.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/message_pipe_endpoint.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/message_pipe_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/message_pipe_unittest.cc View 13 chunks +35 lines, -30 lines 0 comments Download
M mojo/edk/system/remote_data_pipe_impl_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M mojo/edk/system/remote_message_pipe_unittest.cc View 17 chunks +47 lines, -47 lines 0 comments Download
M mojo/edk/system/simple_dispatcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/simple_dispatcher.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/edk/system/wait_set_dispatcher.h View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 6 months ago (2016-06-13 19:13:20 UTC) #1
vardhan
lgtm
4 years, 6 months ago (2016-06-14 16:59:06 UTC) #2
viettrungluu
4 years, 6 months ago (2016-06-14 17:20:20 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
6ff1cf89b1435a6f13662f33a27059eb9d2ba443 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698