Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2068463005: [turbofan] Fix an incorrect comment, and elaborate. (Closed)

Created:
4 years, 6 months ago by bgeron
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] node-marker.h: Fix an incorrect comment, and elaborate. R=bmeurer@chromium.org BUG= Committed: https://crrev.com/c6732a9fb17adec871f9c422e69e82a66bb38690 Cr-Commit-Position: refs/heads/master@{#36994}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M src/compiler/node-marker.h View 1 chunk +16 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
bgeron
Please take a look.
4 years, 6 months ago (2016-06-15 09:57:32 UTC) #1
Benedikt Meurer
lgtm
4 years, 6 months ago (2016-06-15 10:29:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068463005/1
4 years, 6 months ago (2016-06-15 10:30:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-15 10:59:04 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 10:59:39 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c6732a9fb17adec871f9c422e69e82a66bb38690
Cr-Commit-Position: refs/heads/master@{#36994}

Powered by Google App Engine
This is Rietveld 408576698